Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: chrome/browser/resources/help/channel_change_page.js

Issue 423533003: Use PageManager in About page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix settings app browser test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/help/channel_change_page.html ('k') | chrome/browser/resources/help/help.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/help/channel_change_page.js
diff --git a/chrome/browser/resources/help/channel_change_page.js b/chrome/browser/resources/help/channel_change_page.js
index 53be8bc58b3d3ed7a12bd7d98d116bc79c1bb92a..d7c776066c2b42647edb981ca4830568176b71d8 100644
--- a/chrome/browser/resources/help/channel_change_page.js
+++ b/chrome/browser/resources/help/channel_change_page.js
@@ -3,15 +3,20 @@
// found in the LICENSE file.
cr.define('help', function() {
+ var Page = cr.ui.pageManager.Page;
+ var PageManager = cr.ui.pageManager.PageManager;
+
/**
* Encapsulated handling of the channel change overlay.
*/
- function ChannelChangePage() {}
+ function ChannelChangePage() {
+ Page.call(this, 'channel-change-page', '', 'channel-change-page');
+ }
cr.addSingletonGetter(ChannelChangePage);
ChannelChangePage.prototype = {
- __proto__: help.HelpBasePage.prototype,
+ __proto__: Page.prototype,
/**
* Name of the channel the device is currently on.
@@ -46,18 +51,14 @@ cr.define('help', function() {
'selected-channel-good',
'selected-channel-unstable'],
- /**
- * Perform initial setup.
- */
- initialize: function() {
- help.HelpBasePage.prototype.initialize.call(this, 'channel-change-page');
+ /** override */
+ initializePage: function() {
+ Page.prototype.initializePage.call(this);
- var self = this;
-
- $('channel-change-page-cancel-button').onclick = function() {
- help.HelpPage.cancelOverlay();
- };
+ $('channel-change-page-cancel-button').onclick =
+ PageManager.closeOverlay.bind(PageManager);
+ var self = this;
var options = this.getAllChannelOptions_();
for (var i = 0; i < options.length; i++) {
var option = options[i];
@@ -68,17 +69,17 @@ cr.define('help', function() {
$('channel-change-page-powerwash-button').onclick = function() {
self.setChannel_(self.getSelectedOption_(), true);
- help.HelpPage.cancelOverlay();
+ PageManager.closeOverlay();
};
$('channel-change-page-change-button').onclick = function() {
self.setChannel_(self.getSelectedOption_(), false);
- help.HelpPage.cancelOverlay();
+ PageManager.closeOverlay();
};
},
- onBeforeShow: function() {
- help.HelpBasePage.prototype.onBeforeShow.call(this);
+ /** @override */
+ didShowPage: function() {
if (this.targetChannel_ != null)
this.selectOption_(this.targetChannel_);
else if (this.currentChannel_ != null)
@@ -97,7 +98,7 @@ cr.define('help', function() {
* @private
*/
getAllChannelOptions_: function() {
- return $('channel-change-page').querySelectorAll('input[type="radio"]');
+ return this.pageDiv.querySelectorAll('input[type="radio"]');
},
/**
@@ -168,10 +169,10 @@ cr.define('help', function() {
// Switch to the new UI state.
for (var i = 0; i < this.uiClassTable_.length; i++)
- $('channel-change-page').classList.remove(this.uiClassTable_[i]);
+ this.pageDiv.classList.remove(this.uiClassTable_[i]);
if (newOverlayClass)
- $('channel-change-page').classList.add(newOverlayClass);
+ this.pageDiv.classList.add(newOverlayClass);
},
/**
« no previous file with comments | « chrome/browser/resources/help/channel_change_page.html ('k') | chrome/browser/resources/help/help.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698