Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3687)

Unified Diff: chrome/browser/resources/options/options.js

Issue 423533003: Use PageManager in About page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/options.js
diff --git a/chrome/browser/resources/options/options.js b/chrome/browser/resources/options/options.js
index 011223f72c31267a6fac949e2ab30246b3c224aa..5c59c2d0b0f3fc003251aa1760eff536a42233c1 100644
--- a/chrome/browser/resources/options/options.js
+++ b/chrome/browser/resources/options/options.js
@@ -225,7 +225,9 @@ function load() {
OptionsFocusManager.getInstance().initialize();
Preferences.getInstance().initialize();
AutomaticSettingsResetBanner.getInstance().initialize();
+ PageManager.addObserver(new uber.PageManagerObserver());
OptionsPage.initialize();
+ uber.onContentFrameLoaded();
Dan Beam 2014/08/06 18:30:54 why are these calls here and not at the bottom of
michaelpg 2014/08/06 21:58:18 i've moved these around a bit: PageManager.initia
var pageName = PageManager.getPageNameFromPath();
// Still update history so that chrome://settings/nonexistant redirects

Powered by Google App Engine
This is Rietveld 408576698