Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: chrome/browser/ui/webui/help/help_ui.cc

Issue 423533003: Use PageManager in About page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix settings app browser test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/uber/uber_shared.css ('k') | ui/webui/resources/css/overlay.css » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/help/help_ui.h" 5 #include "chrome/browser/ui/webui/help/help_ui.h"
6 6
7 #include "chrome/browser/profiles/profile.h" 7 #include "chrome/browser/profiles/profile.h"
8 #include "chrome/browser/ui/webui/help/help_handler.h" 8 #include "chrome/browser/ui/webui/help/help_handler.h"
9 #include "chrome/common/url_constants.h" 9 #include "chrome/common/url_constants.h"
10 #include "content/public/browser/web_contents.h" 10 #include "content/public/browser/web_contents.h"
11 #include "content/public/browser/web_ui.h" 11 #include "content/public/browser/web_ui.h"
12 #include "content/public/browser/web_ui_data_source.h" 12 #include "content/public/browser/web_ui_data_source.h"
13 #include "grit/browser_resources.h" 13 #include "grit/browser_resources.h"
14 14
15 namespace { 15 namespace {
16 16
17 content::WebUIDataSource* CreateAboutPageHTMLSource() { 17 content::WebUIDataSource* CreateAboutPageHTMLSource() {
18 content::WebUIDataSource* source = 18 content::WebUIDataSource* source =
19 content::WebUIDataSource::Create(chrome::kChromeUIHelpFrameHost); 19 content::WebUIDataSource::Create(chrome::kChromeUIHelpFrameHost);
20 20
21 source->SetJsonPath("strings.js"); 21 source->SetJsonPath("strings.js");
22 source->SetUseJsonJSFormatV2(); 22 source->SetUseJsonJSFormatV2();
23 source->AddResourcePath("help.js", IDR_HELP_JS); 23 source->AddResourcePath("help.js", IDR_HELP_JS);
24 source->AddResourcePath("help_focus_manager.js", IDR_HELP_FOCUS_MANAGER_JS); 24 source->AddResourcePath("help_page.js", IDR_HELP_PAGE_JS);
25 source->AddResourcePath("help_base_page.js", IDR_HELP_BASE_PAGE_JS);
26 source->AddResourcePath("channel_change_page.js", IDR_CHANNEL_CHANGE_PAGE_JS); 25 source->AddResourcePath("channel_change_page.js", IDR_CHANNEL_CHANGE_PAGE_JS);
27 source->SetDefaultResource(IDR_HELP_HTML); 26 source->SetDefaultResource(IDR_HELP_HTML);
28 source->DisableDenyXFrameOptions(); 27 source->DisableDenyXFrameOptions();
29 return source; 28 return source;
30 } 29 }
31 30
32 } // namespace 31 } // namespace
33 32
34 HelpUI::HelpUI(content::WebUI* web_ui) 33 HelpUI::HelpUI(content::WebUI* web_ui)
35 : WebUIController(web_ui) { 34 : WebUIController(web_ui) {
36 Profile* profile = Profile::FromWebUI(web_ui); 35 Profile* profile = Profile::FromWebUI(web_ui);
37 content::WebUIDataSource* source = CreateAboutPageHTMLSource(); 36 content::WebUIDataSource* source = CreateAboutPageHTMLSource();
38 37
39 HelpHandler* handler = new HelpHandler(); 38 HelpHandler* handler = new HelpHandler();
40 handler->GetLocalizedValues(source); 39 handler->GetLocalizedValues(source);
41 content::WebUIDataSource::Add(profile, source); 40 content::WebUIDataSource::Add(profile, source);
42 web_ui->AddMessageHandler(handler); 41 web_ui->AddMessageHandler(handler);
43 } 42 }
44 43
45 HelpUI::~HelpUI() { 44 HelpUI::~HelpUI() {
46 } 45 }
OLDNEW
« no previous file with comments | « chrome/browser/resources/uber/uber_shared.css ('k') | ui/webui/resources/css/overlay.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698