Use PageManager in About page

chrome/browser/resources/options/options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var AddLanguageOverlay = options.AddLanguageOverlay;
 var AlertOverlay = options.AlertOverlay;
 var AutofillEditAddressOverlay = options.AutofillEditAddressOverlay;
 var AutofillEditCreditCardOverlay = options.AutofillEditCreditCardOverlay;
 var AutofillOptions = options.AutofillOptions;
 var AutomaticSettingsResetBanner = options.AutomaticSettingsResetBanner;
@@ skipping 207 matching lines @@
                                 BrowserOptions.getInstance(),
                                 [$('certificatesManageButton')]);
     PageManager.registerOverlay(CertificateRestoreOverlay.getInstance(),
                                 CertificateManager.getInstance());
   }
 
   cr.ui.FocusManager.disableMouseFocusOnButtons();
   OptionsFocusManager.getInstance().initialize();
   Preferences.getInstance().initialize();
   AutomaticSettingsResetBanner.getInstance().initialize();
+  PageManager.addObserver(new uber.PageManagerObserver());
   OptionsPage.initialize();
+  uber.onContentFrameLoaded();

[Dan Beam, 2014/08/06 18:30:54]

why are these calls here and not at the bottom of the method (for example)?

[michaelpg, 2014/08/06 21:58:18]

i've moved these around a bit:

PageManager.initialize has to happen before PageManager.showPageByName, and we
want to add the observer before we start navigating to our given path.

uber.onContentFrameLoaded should actually happen later I think, after
showPageByName has completed, so it registers the correct scroll status.

 
   var pageName = PageManager.getPageNameFromPath();
   // Still update history so that chrome://settings/nonexistant redirects
   // appropriately to chrome://settings/. If the URL matches, updateHistory_
   // will avoid the extra replaceState.
   PageManager.showPageByName(pageName, true, {replaceState: true});
 
   var subpagesNavTabs = document.querySelectorAll('.subpages-nav-tabs');
   for (var i = 0; i < subpagesNavTabs.length; i++) {
     subpagesNavTabs[i].onclick = function(event) {
@@ skipping 18 matching lines @@
 };
 
 /**
  * Listener for the |popstate| event.
  * @param {Event} e The |popstate| event.
  */
 window.onpopstate = function(e) {
   var pageName = PageManager.getPageNameFromPath();
   PageManager.setState(pageName, e.state);
 };