Introduce WindowStateDelegate::ToggleFullscreen

chrome/browser/ui/views/apps/native_app_window_views.cc

Index: chrome/browser/ui/views/apps/native_app_window_views.cc
diff --git a/chrome/browser/ui/views/apps/native_app_window_views.cc b/chrome/browser/ui/views/apps/native_app_window_views.cc
index d5d39fd972f89ea464974c3224b1967934312c08..bbf080c3900cdd26fb9c8c61fc0f26c5b99fc87e 100644
--- a/chrome/browser/ui/views/apps/native_app_window_views.cc
+++ b/chrome/browser/ui/views/apps/native_app_window_views.cc
@@ -4,6 +4,8 @@
 
 #include "chrome/browser/ui/views/apps/native_app_window_views.h"
 
+#include "apps/shell_window.h"
+#include "apps/shell_window_registry.h"
 #include "apps/ui/views/shell_window_frame_view.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
@@ -13,6 +15,7 @@
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/favicon/favicon_tab_helper.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/host_desktop.h"
 #include "chrome/browser/ui/views/extensions/extension_keybinding_registry_views.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_switches.h"
@@ -46,6 +49,7 @@
 #include "ash/wm/custom_frame_view_ash.h"
 #include "ash/wm/panels/panel_frame_view.h"
 #include "ash/wm/window_state.h"
+#include "ash/wm/window_state_delegate.h"
 #include "chrome/browser/ui/ash/ash_util.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/client/window_tree_client.h"
@@ -120,6 +124,40 @@ void CreateIconAndSetRelaunchDetails(
 }
 #endif
 
+#if defined(USE_ASH)
+class NativeAppWindowStateDelegate : public ash::wm::WindowStateDelegate {
+ public:
+  NativeAppWindowStateDelegate(ShellWindow* shell_window)
+      : shell_window_(shell_window) {
+    DCHECK(shell_window_);
+  }
+  virtual ~NativeAppWindowStateDelegate(){}
+
+  virtual bool ToggleFullscreen(ash::wm::WindowState* window_state) OVERRIDE {
+    bool is_fullscreen = window_state->IsFullscreen();
+
+    DCHECK_EQ(

[pkotwicz, 2013/10/29 00:46:01]

Nit: remove the DCHECK

[oshima, 2013/10/29 02:05:42]

Done.

+        apps::ShellWindowRegistry::GetShellWindowForNativeWindowAnyProfile(
+            window_state->window()),
+        shell_window_);
+
+    // Windows which cannot be maximized should not be fullscreened.
+    if (is_fullscreen || window_state->CanMaximize()) {

[pkotwicz, 2013/10/29 00:46:01]

I personally think that testing CanMaximize() here is redundant. But I do not
feel very strongly on this point

If you do keep the check for CanMaximize(), I would rather do this:
if (is_fullscreen) {
  shell_window_->Restore();
} else {
  if (window_state->CanMaximize())
    shell_window_->Fullscreen();
}

[oshima, 2013/10/29 02:05:42]

Done.

+      if (is_fullscreen)
+        shell_window_->Restore();
+      else
+        shell_window_->Fullscreen();
+    }
+    return true;
+  }
+
+ private:
+  ShellWindow* shell_window_;  // not owned.
+
+  DISALLOW_COPY_AND_ASSIGN(NativeAppWindowStateDelegate);
+};
+#endif  // USE_ASH
+
 }  // namespace
 
 NativeAppWindowViews::NativeAppWindowViews(
@@ -151,6 +189,13 @@ NativeAppWindowViews::NativeAppWindowViews(
 
   OnViewWasResized();
   window_->AddObserver(this);
+#if defined(USE_ASH)
+  if (chrome::GetHostDesktopTypeForNativeView(GetNativeWindow()) ==
+      chrome::HOST_DESKTOP_TYPE_ASH) {
+    ash::wm::GetWindowState(GetNativeWindow())->SetDelegate(
+        new NativeAppWindowStateDelegate(shell_window));
+  }
+#endif
 }
 
 NativeAppWindowViews::~NativeAppWindowViews() {