Introduce WindowStateDelegate::ToggleFullscreen

ash/wm/window_state.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_WINDOW_STATE_H_
 #define ASH_WM_WINDOW_STATE_H_
 
 #include "ash/ash_export.h"
 #include "ash/wm/wm_types.h"
 #include "base/basictypes.h"
@@ skipping 104 matching lines @@
   // bounds instead of the restore bounds. Setting this key overrides that
   // behaviour). The flag is reset to the default value after the window is
   // restored.
   bool always_restores_to_restore_bounds() const {
     return always_restores_to_restore_bounds_;
   }
   void set_always_restores_to_restore_bounds(bool value) {
     always_restores_to_restore_bounds_ = value;
   }
 
+  // Sets/gets the flag to use maximized mode instead of
+  // fullscreen. Used for V1 app which has custom window controls.
+  bool maximize_when_fullscreen() const {

[pkotwicz, 2013/10/25 05:16:18]

We need to be careful as to how much we want to respect this attribute.
V1 apps are maximzed instead of put in fullscreen when the user presses the
fullscreen button on the keyboard. A v1 app can still be fullscreened though.
(Chrome remote desktop is a v1 app which most definately can be fullscreened)

Separately I am working on making it possible to put v1 and v2 apps into
immersive fullscreen. I want to have a flag in chrome://flags to do this by the
end of next week.

oshima@, can we further discuss your plans wrt to fullscreen. This is a
fullscreen related CL which will be landing on Friday (today)
https://codereview.chromium.org/32943006/

+    return maximize_when_fullscreen_;
+  }
+  void set_maximize_when_fullscreen(bool value) {
+    maximize_when_fullscreen_ = value;
+  }
+
+  // Sets/gets the flag to suppress the cross-fade animation for
+  // the transition to the fullscreen state.
+  bool animate_to_fullscreen() const {
+    return animate_to_fullscreen_;
+  }
+  void set_animate_to_fullscreen(bool value) {
+    animate_to_fullscreen_ = value;
+  }
+
   // Gets/Sets the bounds of the window before it was moved by the auto window
   // management. As long as it was not auto-managed, it will return NULL.
   const gfx::Rect* pre_auto_manage_window_bounds() const {
     return pre_auto_manage_window_bounds_.get();
   }
   void SetPreAutoManageWindowBounds(const gfx::Rect& bounds);
 
   // Layout related properties
 
   void AddObserver(WindowStateObserver* observer);
@@ skipping 75 matching lines @@
   aura::Window* window_;
 
   bool tracked_by_workspace_;
   bool window_position_managed_;
   bool bounds_changed_by_user_;
   bool panel_attached_;
   bool continue_drag_after_reparent_;
   bool ignored_by_shelf_;
   bool can_consume_system_keys_;
   bool top_row_keys_are_function_keys_;
-
   bool always_restores_to_restore_bounds_;
+  bool maximize_when_fullscreen_;
+  bool animate_to_fullscreen_;
 
   // A property to remember the window position which was set before the
   // auto window position manager changed the window bounds, so that it can get
   // restored when only this one window gets shown.
   scoped_ptr<gfx::Rect> pre_auto_manage_window_bounds_;
 
   ObserverList<WindowStateObserver> observer_list_;
 
   WindowShowType window_show_type_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowState);
 };
 
 // Returns the WindowState for active window. Returns |NULL|
 // if there is no active window.
 ASH_EXPORT WindowState* GetActiveWindowState();
 
 // Returns the WindowState for |window|. Creates WindowState
 // if it didn't exist. The settings object is owned by |window|.
 ASH_EXPORT WindowState* GetWindowState(aura::Window* window);
 
 // const version of GetWindowState.
 ASH_EXPORT const WindowState*
 GetWindowState(const aura::Window* window);
 
 }  // namespace wm
 }  // namespace ash
 
 #endif  // ASH_WM_WINDOW_STATE_H_