Introduce WindowStateDelegate::ToggleFullscreen

ash/wm/window_state_delegate.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_WM_WINDOW_STATE_DELEGATE_H_
+#define ASH_WM_WINDOW_STATE_DELEGATE_H_
+
+#include "ash/ash_export.h"
+#include "base/basictypes.h"
+
+namespace ash {
+namespace wm {
+class WindowState;
+
+class ASH_EXPORT WindowStateDelegate {
+ public:
+  WindowStateDelegate();
+  virtual ~WindowStateDelegate();
+
+  // Invoked when the user uses Shift+F4 to toggle the window fullscreen state.

[pkotwicz, 2013/10/25 19:56:38]

F4 toggles fullscreen too.

I would rather have two methods EnterFullscreen() and ExitFullscreen().
In order to implement putting v1 and v2 packaged apps into immersive fullscreen,
I will add
EnterImmersiveFullscreen() (Possibly removing EnterFullscreen())

Planned behavior for v2 apps:
- Pressing <F4> should enter immersive fullscreen
- chrome.app.window.current().fullscreen() (aka ShellWindow::Fullscreen())
should not enter immersive fullscreen.
I am really concerned about confusion as to what ToggleFullscreen() does once I
make that change.

[oshima, 2013/10/25 22:36:20]

What I'm hoping for is that Restore() can restore chrome properly, so just
EnterFullscreen but no ExitFullscreen.

In any case, these change will be in separate CL.

+  virtual bool ToggleFullscreen(WindowState* window_state);
+ private:
+  DISALLOW_COPY_AND_ASSIGN(WindowStateDelegate);
+};
+
+}  // namespace wm
+}  // namespace ash
+
+#endif  // ASH_WM_WINDOW_STATE_DELEGATE_H_