Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 42352: WebKit Merge 41768:41807, Chromium Side (Closed)

Created:
11 years, 9 months ago by dglazkov
Modified:
9 years, 6 months ago
Reviewers:
ojan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

WebKit Merge 41768:41807, Chromium Side R=ojan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12013

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+796 lines, -615 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M WEBKIT_MERGE_REVISION View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/chrome/fast/forms/textarea-metrics-expected.txt View 2 chunks +9 lines, -9 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt View 1 chunk +33 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/forms/textarea-appearance-wrap-expected.txt View 1 chunk +30 lines, -0 lines 2 comments Download
A webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/forms/textarea-hard-linewrap-expected.txt View 1 chunk +7 lines, -0 lines 2 comments Download
A webkit/data/layout_tests/platform/chromium-mac/chrome/fast/forms/textarea-metrics-expected.txt View 1 chunk +79 lines, -0 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/4960120-1-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/6633727-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/6633727-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/6633727-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/insert-div-021-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/nested-blocks-with-text-area-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/pasting-tabs-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/block/float/overlapping-floats-with-overflow-hidden-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/block/float/overlapping-floats-with-overflow-hidden-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/block/margin-collapse/103-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/resize-corner-tracking-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt View 1 chunk +33 lines, -0 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dynamic/008-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/form-element-geometry-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/negativeLineHeight-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/negativeLineHeight-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/negativeLineHeight-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textAreaLineHeight-expected.txt View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-align-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-appearance-wrap-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-hard-linewrap-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scroll-height-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrollbar-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrolled-type-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-setinnerhtml-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-width-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-width-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-width-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-x-y-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/parser/comment-in-textarea-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/parser/comment-in-textarea-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/parser/comment-in-textarea-expected.txt View 1 chunk +10 lines, -11 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/parser/entity-comment-in-textarea-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/parser/open-comment-in-textarea-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/width100percent-textarea-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/003-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/text/international/rtl-white-space-pre-wrap-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/text/international/rtl-white-space-pre-wrap-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/text/international/rtl-white-space-pre-wrap-expected.txt View 1 chunk +3 lines, -5 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/anchor-basic-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/anchor-frames-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/anchor-goback-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/anchor-subframeload-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/javascriptlink-basic-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/javascriptlink-frames-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/javascriptlink-goback-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/javascriptlink-subframeload-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/metaredirect-basic-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/metaredirect-frames-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/metaredirect-goback-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/metaredirect-subframeload-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/post-goback2-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/postredirect-goback2-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/redirect302-basic-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/redirect302-frames-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/redirect302-goback-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/redirect302-subframeload-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/relativeanchor-basic-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/relativeanchor-frames-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/relativeanchor-goback-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/slowmetaredirect-basic-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/slowtimerredirect-basic-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/success200-basic-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/success200-frames-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/success200-frames-loadsame-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/success200-goback-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/success200-loadsame-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/success200-reload-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/success200-subframeload-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/timerredirect-basic-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/timerredirect-frames-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/timerredirect-goback-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/navigation/timerredirect-subframeload-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug194024-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug30559-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug30692-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/chrome/fast/forms/basic-textareas-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/chrome/fast/forms/basic-textareas-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/chrome/fast/forms/basic-textareas-expected.txt View 4 chunks +21 lines, -21 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/chrome/fast/forms/basic-textareas-quirks-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/chrome/fast/forms/basic-textareas-quirks-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/chrome/fast/forms/basic-textareas-quirks-expected.txt View 5 chunks +340 lines, -385 lines 0 comments Download
M webkit/tools/layout_tests/test_lists/tests_fixable.txt View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dglazkov
11 years, 9 months ago (2009-03-18 20:01:07 UTC) #1
ojan
LGTM. I have two questions about tests that say they fail. Looks like rebasing them ...
11 years, 9 months ago (2009-03-18 20:34:31 UTC) #2
dglazkov
11 years, 9 months ago (2009-03-18 21:01:06 UTC) #3
http://codereview.chromium.org/42352/diff/1/5
File
webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/forms/textarea-appearance-wrap-expected.txt
(right):

http://codereview.chromium.org/42352/diff/1/5#newcode8
Line 8: wrap=hard : Failure
No. I'll move this to failing.

http://codereview.chromium.org/42352/diff/1/4
File
webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/forms/textarea-hard-linewrap-expected.txt
(right):

http://codereview.chromium.org/42352/diff/1/4#newcode6
Line 6: Failure. The form data that should have been submitted:
textarea=1234567%0D%0A89
On 2009/03/18 20:34:31, ojan wrote:
> This looks like it's failing. Does this fail like this upstream as well?

Ditto.

Powered by Google App Engine
This is Rietveld 408576698