Make ScopedWindowTargeter add itself as a WindowObserver for real

Make ScopedWindowTargeter add itself as a WindowObserver for real

BUG=None
TEST=WindowTargeterTest.ScopedWindowTargeterWindowDestroyed

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285776

[pkotwicz, 2014-07-25 14:31:22]

Sadrul, PTAL

I came across this while investigating why tests crashed if the test ended
without exiting overview mode first

[Jun Mukai, 2014-07-25 20:24:00]

https://codereview.chromium.org/423503002/diff/20001/ui/aura/scoped_window_ta...
File ui/aura/scoped_window_targeter.cc (right):

https://codereview.chromium.org/423503002/diff/20001/ui/aura/scoped_window_ta...
ui/aura/scoped_window_targeter.cc:28: window_->RemoveObserver(this);
aura::Window destructor removes the observer right before OnWindowDestroyed.

[pkotwicz, 2014-07-25 20:31:21]

https://codereview.chromium.org/423503002/diff/20001/ui/aura/scoped_window_ta...
File ui/aura/scoped_window_targeter.cc (right):

https://codereview.chromium.org/423503002/diff/20001/ui/aura/scoped_window_ta...
ui/aura/scoped_window_targeter.cc:28: window_->RemoveObserver(this);
You're right. Thanks for letting me know!

[sadrul, 2014-07-25 20:37:49]

Thanks! LGTM

[pkotwicz, 2014-07-25 20:44:38]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-07-25 20:46:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/423503002/40001

[commit-bot: I haz the power, 2014-07-26 00:13:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-26 18:32:54]

Change committed as 285776