Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 423473008: [usb_gadget p13] Replace LUFA with UsbTestGadget in HidConnection tests. (Closed)

Created:
6 years, 5 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[usb_gadget p13] Replace LUFA with UsbTestGadget in HidConnection tests. The culmination of all this USB gadget nonsense... the HidConnection tests can now use the USB gadget framework I have built to validate device I/O works. This replaces the code based on a specially programmed Arduino running the LUFA library. BUG=396682 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287364

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -73 lines) Patch
M device/hid/hid_connection_unittest.cc View 2 chunks +78 lines, -73 lines 0 comments Download
M device/test/usb_test_gadget.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/test/usb_test_gadget_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/usb_gadget.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/usb_gadget/__main__.py View 2 chunks +2 lines, -0 lines 0 comments Download
A tools/usb_gadget/hid_echo_gadget.py View 1 chunk +105 lines, -0 lines 0 comments Download
M tools/usb_gadget/usb_constants.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Reilly Grant (use Gerrit)
6 years, 5 months ago (2014-07-25 23:20:18 UTC) #1
Reilly Grant (use Gerrit)
Adding more reviewers as this is the first "real" test using this framework.
6 years, 4 months ago (2014-07-28 17:44:38 UTC) #2
Reilly Grant (use Gerrit)
6 years, 4 months ago (2014-07-29 20:44:24 UTC) #3
Ken Rockot(use gerrit already)
lgtm
6 years, 4 months ago (2014-08-04 15:12:09 UTC) #4
Reilly Grant (use Gerrit)
The CQ bit was checked by reillyg@chromium.org
6 years, 4 months ago (2014-08-04 15:13:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/423473008/40001
6 years, 4 months ago (2014-08-04 15:14:00 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 18:08:22 UTC) #7
Message was sent while issue was closed. 
Change committed as 287364

Powered by Google App Engine
This is Rietveld 408576698