Refactor AppWindow to enable code re-use with launcher pages.

Refactor AppWindow to enable code re-use with launcher pages.

Created a new class AppWebContentsHelper and moved the implementation of
several WebContentsDelegate methods (those which are not specific to app
windows) from AppWindow to there. AppWindow just calls those methods.
This will enable custom launcher pages to implement WebContentsDelegate
without duplicating a lot of code from AppWindow.

BUG=399116
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287302

[Matt Giuca, 2014-07-31 00:14:14]

Part II.

[benwells, 2014-07-31 06:20:29]

https://codereview.chromium.org/423453002/diff/20001/apps/app_web_contents_he...
File apps/app_web_contents_helper.h (right):

https://codereview.chromium.org/423453002/diff/20001/apps/app_web_contents_he...
apps/app_web_contents_helper.h:54: const extensions::Extension* GetExtension()
const;
Why is this and browser_context() public?

https://codereview.chromium.org/423453002/diff/20001/apps/app_web_contents_he...
apps/app_web_contents_helper.h:73: AppDelegate* app_delegate_;
DISALLOW_COPY_AND_ASSIGN

[Matt Giuca, 2014-08-01 04:49:29]

Oops I prepared this ages ago but forgot to hit Mail.

https://codereview.chromium.org/423453002/diff/20001/apps/app_web_contents_he...
File apps/app_web_contents_helper.h (right):

https://codereview.chromium.org/423453002/diff/20001/apps/app_web_contents_he...
apps/app_web_contents_helper.h:54: const extensions::Extension* GetExtension()
const;
Not sure, I assume historical reasons!

Deleted browser_context(), made GetExtension private.

https://codereview.chromium.org/423453002/diff/20001/apps/app_web_contents_he...
apps/app_web_contents_helper.h:73: AppDelegate* app_delegate_;
On 2014/07/31 06:20:29, benwells wrote:
> DISALLOW_COPY_AND_ASSIGN

Done.

[benwells, 2014-08-04 01:31:35]

lgtm

[Matt Giuca, 2014-08-04 04:51:06]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-08-04 04:51:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/423453002/40001

[commit-bot: I haz the power, 2014-08-04 05:38:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/36930)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-04 05:39:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-04 05:39:17]

Try jobs failed on following builders:
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

[Matt Giuca, 2014-08-04 06:00:59]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-08-04 06:01:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/423453002/60001

[commit-bot: I haz the power, 2014-08-04 07:59:10]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)

[commit-bot: I haz the power, 2014-08-04 08:04:43]

Change committed as 287302