Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 423433006: [SyncFS] Implement RemoveUnreachableItems for MetadataDatabaseIndexOnDisk (Closed)

Created:
6 years, 4 months ago by peria
Modified:
6 years, 4 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Implement RemoveUnreachableItems for MetadataDatabaseIndexOnDisk BUG=347425 TEST=./unit_tests --gtest_filter="Metadata*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287715

Patch Set 1 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -23 lines) Patch
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc View 3 chunks +111 lines, -0 lines 3 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc View 14 chunks +71 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
peria
PTL
6 years, 4 months ago (2014-08-04 09:12:14 UTC) #1
tzik
lgtm
6 years, 4 months ago (2014-08-05 06:20:59 UTC) #2
nhiroki
Looks good overall. https://codereview.chromium.org/423433006/diff/80001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc (right): https://codereview.chromium.org/423433006/diff/80001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc#newcode259 chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:259: index(new MetadataDatabaseIndexOnDisk(db)); When is |db| committed?
6 years, 4 months ago (2014-08-05 07:19:17 UTC) #3
peria
https://codereview.chromium.org/423433006/diff/80001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc (right): https://codereview.chromium.org/423433006/diff/80001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc#newcode259 chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:259: index(new MetadataDatabaseIndexOnDisk(db)); On 2014/08/05 07:19:16, nhiroki wrote: > When ...
6 years, 4 months ago (2014-08-05 07:36:00 UTC) #4
nhiroki
lgtm https://codereview.chromium.org/423433006/diff/80001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc (right): https://codereview.chromium.org/423433006/diff/80001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc#newcode259 chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:259: index(new MetadataDatabaseIndexOnDisk(db)); On 2014/08/05 07:35:59, peria wrote: > ...
6 years, 4 months ago (2014-08-05 09:21:50 UTC) #5
peria
The CQ bit was checked by peria@chromium.org
6 years, 4 months ago (2014-08-06 00:49:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/423433006/80001
6 years, 4 months ago (2014-08-06 00:50:40 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 06:47:21 UTC) #8
Message was sent while issue was closed. 
Change committed as 287715

Powered by Google App Engine
This is Rietveld 408576698