Source/core/editing/CompositeEditCommand.h - Issue 423413005: Use tighter typing in editing: ReplaceSelectionCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/CompositeEditCommand.h

Issue 423413005: Use tighter typing in editing: ReplaceSelectionCommand (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Revert bad change Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/CompositeEditCommand.h

diff --git a/Source/core/editing/CompositeEditCommand.h b/Source/core/editing/CompositeEditCommand.h

index 2d5614ac1cd51ebadf234a67c6791e78f6b67e23..b0ebf2a5d14de9d1a0a30d50f9b7b00b361211de 100644

--- a/Source/core/editing/CompositeEditCommand.h

+++ b/Source/core/editing/CompositeEditCommand.h

@@ -120,7 +120,7 @@ protected:

bool canRebalance(const Position&) const;

bool shouldRebalanceLeadingWhitespaceFor(const String&) const;

void removeCSSProperty(PassRefPtrWillBeRawPtr<Element>, CSSPropertyID);

- void removeNodeAttribute(PassRefPtrWillBeRawPtr<Element>, const QualifiedName& attribute);

+ void removeElementAttribute(PassRefPtrWillBeRawPtr<Element>, const QualifiedName& attribute);

void removeChildrenInRange(PassRefPtrWillBeRawPtr<Node>, unsigned from, unsigned to);

virtual void removeNode(PassRefPtrWillBeRawPtr<Node>, ShouldAssumeContentIsAlwaysEditable = DoNotAssumeContentIsAlwaysEditable);

HTMLSpanElement* replaceElementWithSpanPreservingChildrenAndAttributes(PassRefPtrWillBeRawPtr<HTMLElement>);