Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 423393010: Adjust addends rather than targets for RELA configurations. (Closed)

Created:
6 years, 4 months ago by simonb (inactive)
Modified:
6 years, 4 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adjust addends rather than targets for RELA configurations. Relocations with addend use the addend rather that the location pointed to by the relocation as the target of the relocations. For RELA relocations, ignore the target and instead adjust the addend for the hole being created in the file. Change unit test data accordingly. Ensure that sections we resize are never zero-length when we load the Elf file, and that we never set either to zero-length on packing. BUG=385553 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287354

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -42 lines) Patch
M tools/relocation_packer/src/elf_file.cc View 7 chunks +88 lines, -42 lines 1 comment Download
M tools/relocation_packer/test_data/elf_file_unittest_relocs_arm64_packed.so View Binary file 0 comments Download

Messages

Total messages: 5 (0 generated)
simonb (inactive)
6 years, 4 months ago (2014-08-04 10:57:05 UTC) #1
rmcilroy
lgtm https://codereview.chromium.org/423393010/diff/1/tools/relocation_packer/src/elf_file.cc File tools/relocation_packer/src/elf_file.cc (right): https://codereview.chromium.org/423393010/diff/1/tools/relocation_packer/src/elf_file.cc#newcode695 tools/relocation_packer/src/elf_file.cc:695: void AdjustRelocation(ssize_t index, AdjustRelocationTarget?
6 years, 4 months ago (2014-08-04 12:12:50 UTC) #2
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 4 months ago (2014-08-04 13:28:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/423393010/1
6 years, 4 months ago (2014-08-04 13:29:51 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 17:10:31 UTC) #5
Message was sent while issue was closed.
Change committed as 287354

Powered by Google App Engine
This is Rietveld 408576698