Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/x87/stub-cache-x87.cc

Issue 423393003: X87: Only generate a single normal IC per kind per slow-mode map. (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 1281 matching lines...) Expand 10 before | Expand all | Expand 10 after
1292 1292
1293 Handle<Code> PropertyICCompiler::CompilePolymorphic(TypeHandleList* types, 1293 Handle<Code> PropertyICCompiler::CompilePolymorphic(TypeHandleList* types,
1294 CodeHandleList* handlers, 1294 CodeHandleList* handlers,
1295 Handle<Name> name, 1295 Handle<Name> name,
1296 Code::StubType type, 1296 Code::StubType type,
1297 IcCheckType check) { 1297 IcCheckType check) {
1298 Label miss; 1298 Label miss;
1299 1299
1300 if (check == PROPERTY && 1300 if (check == PROPERTY &&
1301 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) { 1301 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) {
1302 __ cmp(this->name(), Immediate(name)); 1302 // In case we are compiling an IC for dictionary loads and stores, just
1303 __ j(not_equal, &miss); 1303 // check whether the name is unique.
1304 if (name.is_identical_to(isolate()->factory()->normal_ic_symbol())) {
1305 __ JumpIfNotUniqueName(this->name(), &miss);
1306 } else {
1307 __ cmp(this->name(), Immediate(name));
1308 __ j(not_equal, &miss);
1309 }
1304 } 1310 }
1305 1311
1306 Label number_case; 1312 Label number_case;
1307 Label* smi_target = IncludesNumberType(types) ? &number_case : &miss; 1313 Label* smi_target = IncludesNumberType(types) ? &number_case : &miss;
1308 __ JumpIfSmi(receiver(), smi_target); 1314 __ JumpIfSmi(receiver(), smi_target);
1309 1315
1310 // Polymorphic keyed stores may use the map register 1316 // Polymorphic keyed stores may use the map register
1311 Register map_reg = scratch1(); 1317 Register map_reg = scratch1();
1312 ASSERT(kind() != Code::KEYED_STORE_IC || 1318 ASSERT(kind() != Code::KEYED_STORE_IC ||
1313 map_reg.is(KeyedStoreIC::MapRegister())); 1319 map_reg.is(KeyedStoreIC::MapRegister()));
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
1387 // ----------------------------------- 1393 // -----------------------------------
1388 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1394 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1389 } 1395 }
1390 1396
1391 1397
1392 #undef __ 1398 #undef __
1393 1399
1394 } } // namespace v8::internal 1400 } } // namespace v8::internal
1395 1401
1396 #endif // V8_TARGET_ARCH_X87 1402 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698