Chromium Code Reviews
DescriptionRevert of Move Html and BuildbotPageMeasurementResults to {Html,Buildbot}OutputFormatter. (https://codereview.chromium.org/421503005/)
Reason for revert:
[ RUN ] page_runner_unittest.PageRunnerTests.testPagesetRepeat
WARNING:root:Could not find Flash at /mnt/data/b/build/slave/Linux_Tests/build/src/third_party/adobe/flash/binaries/ppapi/linux/libpepflashplayer.so. Continuing without Flash.
To run with Flash, check it out via http://go/read-src-internal
Traceback (most recent call last):
run at /usr/lib/python2.7/unittest/case.py:327
testMethod()
wrapper at tools/telemetry/telemetry/decorators.py:55
func(*args, **kwargs)
testPagesetRepeat at tools/telemetry/telemetry/page/page_runner_unittest.py:241
results._output_stream.close() # pylint: disable=W0212
AttributeError: 'NoneType' object has no attribute 'close'
Locals:
Measurement : <class 'telemetry.page.page_runner_unittest.Measurement'>
expectations : <telemetry.page.test_expectations.TestExpectations object at 0x315f610>
f : <closed file '/tmp/tmpJPzPHo', mode 'r' at 0x2b549c0>
options : [('android_device', None), ('android_rndis', False), ('browser_executable', None), ('browser_options', [('_extra_browser_args', set([])), ('browser_type', 'release'), ('browser_user_agent_type', None), ('clear_sytem_cache_for_browser_and_profile_on_start', False), ('disable_component_extensions_with_background_pages', True), ('dont_override_profile', False), ('extra_wpr_args', []), ('netsim', None), ('no_proxy_server', False), ('profile_dir', None), ('profile_type', 'clean'), ('show_stdout', False), ('st ... _order_file', None), ('positional_args', []), ('print_bootstrap_deps', None), ('profile_dir', None), ('profile_type', 'clean'), ('profiler', None), ('repeat_count', 1), ('reset_results', None), ('results_label', None), ('run_disabled_tests', False), ('show_stdout', None), ('skip_navigate_on_repeat', False), ('synthetic_gesture_source_type', 'default'), ('upload_results', None), ('use_devtools_active_port', None), ('use_live_sites', None), ('verbosity', 0), ('write_full_results_to', '/tmp/tmpjhD2qP.json')] (truncated)
output_file : '/tmp/tmpJPzPHo'
ps : <telemetry.page.page_set.PageSet object at 0x315f250>
results : <telemetry.results.page_test_results.PageTestResults object at 0x315f0d0>
stdout : 'RESULT metric: blank.html= [1,3] unit\nAvg metric: 2.000000unit\nSd metric: 1.414214unit\nRESULT metric: green_rect.html= [2,4] unit\nAvg metric: 3.000000unit\nSd metric: 1.414214unit\n*RESULT metric: metric= [1,2,3,4] unit\nAvg metric: 2.500000unit\nSd metric: 1.290994unit\nRESULT telemetry_page_measurement_results: num_failed= 0 count\nRESULT telemetry_page_measurement_results: num_errored= 0 count\n'
Pages: [blank.html,green_rect.html]
[ FAILED ] page_runner_unittest.PageRunnerTests.testPagesetRepeat (1883 ms)
Original issue's description:
> Move Html and BuildbotPageMeasurementResults to {Html,Buildbot}OutputFormatter.
>
> This preserved the current output of each
> --output-format=buildbot|html. We may want to simplify the output for
> --output-format=html.
>
> Refactored results_options.py slightly to better accommodate
> OutputFormatter (now --output-format=none is also using
> OutputFormatter code path).
>
> BUG=346956
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286445
TBR=nednguyen@google.com,chrishenry@google.com
NOTREECHECKS=true
NOTRY=true
BUG=346956
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286524
Patch Set 1 #
Created: 6 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|