Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 423383004: Revert of Move Html and BuildbotPageMeasurementResults to {Html,Buildbot}OutputFormatter. (Closed)

Created:
6 years, 4 months ago by tonyg
Modified:
6 years, 4 months ago
Reviewers:
nednguyen, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Move Html and BuildbotPageMeasurementResults to {Html,Buildbot}OutputFormatter. (https://codereview.chromium.org/421503005/) Reason for revert: [ RUN ] page_runner_unittest.PageRunnerTests.testPagesetRepeat WARNING:root:Could not find Flash at /mnt/data/b/build/slave/Linux_Tests/build/src/third_party/adobe/flash/binaries/ppapi/linux/libpepflashplayer.so. Continuing without Flash. To run with Flash, check it out via http://go/read-src-internal Traceback (most recent call last): run at /usr/lib/python2.7/unittest/case.py:327 testMethod() wrapper at tools/telemetry/telemetry/decorators.py:55 func(*args, **kwargs) testPagesetRepeat at tools/telemetry/telemetry/page/page_runner_unittest.py:241 results._output_stream.close() # pylint: disable=W0212 AttributeError: 'NoneType' object has no attribute 'close' Locals: Measurement : <class 'telemetry.page.page_runner_unittest.Measurement'> expectations : <telemetry.page.test_expectations.TestExpectations object at 0x315f610> f : <closed file '/tmp/tmpJPzPHo', mode 'r' at 0x2b549c0> options : [('android_device', None), ('android_rndis', False), ('browser_executable', None), ('browser_options', [('_extra_browser_args', set([])), ('browser_type', 'release'), ('browser_user_agent_type', None), ('clear_sytem_cache_for_browser_and_profile_on_start', False), ('disable_component_extensions_with_background_pages', True), ('dont_override_profile', False), ('extra_wpr_args', []), ('netsim', None), ('no_proxy_server', False), ('profile_dir', None), ('profile_type', 'clean'), ('show_stdout', False), ('st ... _order_file', None), ('positional_args', []), ('print_bootstrap_deps', None), ('profile_dir', None), ('profile_type', 'clean'), ('profiler', None), ('repeat_count', 1), ('reset_results', None), ('results_label', None), ('run_disabled_tests', False), ('show_stdout', None), ('skip_navigate_on_repeat', False), ('synthetic_gesture_source_type', 'default'), ('upload_results', None), ('use_devtools_active_port', None), ('use_live_sites', None), ('verbosity', 0), ('write_full_results_to', '/tmp/tmpjhD2qP.json')] (truncated) output_file : '/tmp/tmpJPzPHo' ps : <telemetry.page.page_set.PageSet object at 0x315f250> results : <telemetry.results.page_test_results.PageTestResults object at 0x315f0d0> stdout : 'RESULT metric: blank.html= [1,3] unit\nAvg metric: 2.000000unit\nSd metric: 1.414214unit\nRESULT metric: green_rect.html= [2,4] unit\nAvg metric: 3.000000unit\nSd metric: 1.414214unit\n*RESULT metric: metric= [1,2,3,4] unit\nAvg metric: 2.500000unit\nSd metric: 1.290994unit\nRESULT telemetry_page_measurement_results: num_failed= 0 count\nRESULT telemetry_page_measurement_results: num_errored= 0 count\n' Pages: [blank.html,green_rect.html] [ FAILED ] page_runner_unittest.PageRunnerTests.testPagesetRepeat (1883 ms) Original issue's description: > Move Html and BuildbotPageMeasurementResults to {Html,Buildbot}OutputFormatter. > > This preserved the current output of each > --output-format=buildbot|html. We may want to simplify the output for > --output-format=html. > > Refactored results_options.py slightly to better accommodate > OutputFormatter (now --output-format=none is also using > OutputFormatter code path). > > BUG=346956 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286445 TBR=nednguyen@google.com,chrishenry@google.com NOTREECHECKS=true NOTRY=true BUG=346956 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+395 lines, -989 lines) Patch
D tools/telemetry/telemetry/results/buildbot_output_formatter.py View 1 chunk +0 lines, -110 lines 0 comments Download
D tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py View 1 chunk +0 lines, -469 lines 0 comments Download
D tools/telemetry/telemetry/results/html_output_formatter.py View 1 chunk +0 lines, -131 lines 0 comments Download
D tools/telemetry/telemetry/results/html_output_formatter_unittest.py View 1 chunk +0 lines, -250 lines 0 comments Download
A tools/telemetry/telemetry/results/html_page_measurement_results.py View 1 chunk +130 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/results/html_page_measurement_results_unittest.py View 1 chunk +247 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/results/output_formatter.py View 2 chunks +1 line, -5 lines 0 comments Download
M tools/telemetry/telemetry/results/results_options.py View 3 chunks +16 lines, -23 lines 0 comments Download
M tools/telemetry/telemetry/value/summary_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tonyg
Created Revert of Move Html and BuildbotPageMeasurementResults to {Html,Buildbot}OutputFormatter.
6 years, 4 months ago (2014-07-30 16:07:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/423383004/1
6 years, 4 months ago (2014-07-30 16:08:39 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 16:09:49 UTC) #3
Message was sent while issue was closed.
Change committed as 286524

Powered by Google App Engine
This is Rietveld 408576698