Issue 423373003: CC: Support fractional iteration count on compositor animations

Issue 423373003: CC: Support fractional iteration count on compositor animations (Closed)

Created:
6 years, 4 months ago by samli

Modified:
6 years, 4 months ago

Reviewers:
ajuma, nduca, enne (OOO)

CC:
alancutter (OOO until 2018), cc-bugs_hromium.org, chromium-reviews, darin-cc_chromium.org, dstockwell, jam, Ian Vollick

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

CC: Support fractional iteration count on compositor animations BUG=398767 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288931

Patch Set 3 : Rebase and review changes #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -9 lines)			Patch
M	cc/animation/animation.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	cc/animation/animation.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	cc/animation/animation_unittest.cc	View	1 2	4 chunks	+31 lines, -4 lines	0 comments	Download
M	content/renderer/compositor_bindings/web_animation_impl.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/renderer/compositor_bindings/web_animation_impl.cc	View	1 2	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

samli

+enne Still requires OWNERs approval for content/renderer/compositor_bindings

6 years, 4 months ago (2014-08-11 04:19:19 UTC) #4

enne (OOO)

lgtm https://codereview.chromium.org/423373003/diff/40001/cc/animation/animation_unittest.cc File cc/animation/animation_unittest.cc (right): https://codereview.chromium.org/423373003/diff/40001/cc/animation/animation_unittest.cc#newcode53 cc/animation/animation_unittest.cc:53: EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TicksFromSecondsF(-1.0))); style nit: 0.0, here and elsewhere

6 years, 4 months ago (2014-08-11 20:01:22 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samli@chromium.org/423373003/60001

6 years, 4 months ago (2014-08-12 02:50:48 UTC) #7

Message was sent while issue was closed.

Change committed as 288931

Expand Messages | Collapse Messages