Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2064)

Unified Diff: device/serial/serial_io_handler_posix.cc

Issue 423373002: Convert SerialIoHandler to use buffer interfaces for I/O API methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@js-serial
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/serial/serial_io_handler_posix.cc
diff --git a/device/serial/serial_io_handler_posix.cc b/device/serial/serial_io_handler_posix.cc
index 0bb6d6598f5ebb2ac4bcd204362566c1cd0e3caf..a215661be11586b02dad4c2194686cbe51bd1318 100644
--- a/device/serial/serial_io_handler_posix.cc
+++ b/device/serial/serial_io_handler_posix.cc
@@ -173,7 +173,7 @@ void SerialIoHandlerPosix::OnFileCanReadWithoutBlocking(int fd) {
if (pending_read_buffer()) {
int bytes_read = HANDLE_EINTR(read(file().GetPlatformFile(),
- pending_read_buffer()->data(),
+ pending_read_buffer(),
pending_read_buffer_len()));
if (bytes_read < 0) {
if (errno == ENXIO) {
@@ -200,7 +200,7 @@ void SerialIoHandlerPosix::OnFileCanWriteWithoutBlocking(int fd) {
if (pending_write_buffer()) {
int bytes_written = HANDLE_EINTR(write(file().GetPlatformFile(),
- pending_write_buffer()->data(),
+ pending_write_buffer(),
pending_write_buffer_len()));
if (bytes_written < 0) {
WriteCompleted(0, serial::SEND_ERROR_SYSTEM_ERROR);

Powered by Google App Engine
This is Rietveld 408576698