Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1889)

Unified Diff: test/cctest/compiler/compiler/test-js-constant-cache.cc

Issue 423313004: Remove accidental duplication in cctest suite. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/compiler/compiler/test-js-constant-cache.cc
diff --git a/test/cctest/compiler/compiler/test-js-constant-cache.cc b/test/cctest/compiler/compiler/test-js-constant-cache.cc
deleted file mode 100644
index 42a606d23c5a2010ae4aeb9a4b8b93d9163c5140..0000000000000000000000000000000000000000
--- a/test/cctest/compiler/compiler/test-js-constant-cache.cc
+++ /dev/null
@@ -1,284 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "src/v8.h"
-
-#include "src/compiler/js-graph.h"
-#include "src/compiler/node-properties-inl.h"
-#include "src/compiler/typer.h"
-#include "src/types.h"
-#include "test/cctest/cctest.h"
-#include "test/cctest/compiler/value-helper.h"
-
-using namespace v8::internal;
-using namespace v8::internal::compiler;
-
-class JSCacheTesterHelper {
- protected:
- explicit JSCacheTesterHelper(Zone* zone)
- : main_graph_(zone), main_common_(zone), main_typer_(zone) {}
- Graph main_graph_;
- CommonOperatorBuilder main_common_;
- Typer main_typer_;
-};
-
-
-class JSConstantCacheTester : public HandleAndZoneScope,
- public JSCacheTesterHelper,
- public JSGraph {
- public:
- JSConstantCacheTester()
- : JSCacheTesterHelper(main_zone()),
- JSGraph(&main_graph_, &main_common_, &main_typer_) {}
-
- Type* upper(Node* node) { return NodeProperties::GetBounds(node).upper; }
-
- Handle<Object> handle(Node* node) {
- CHECK_EQ(IrOpcode::kHeapConstant, node->opcode());
- return ValueOf<Handle<Object> >(node->op());
- }
-
- Factory* factory() { return main_isolate()->factory(); }
-};
-
-
-TEST(ZeroConstant1) {
- JSConstantCacheTester T;
-
- Node* zero = T.ZeroConstant();
-
- CHECK_EQ(IrOpcode::kNumberConstant, zero->opcode());
- CHECK_EQ(zero, T.Constant(0));
- CHECK_NE(zero, T.Constant(-0.0));
- CHECK_NE(zero, T.Constant(1.0));
- CHECK_NE(zero, T.Constant(v8::base::OS::nan_value()));
- CHECK_NE(zero, T.Float64Constant(0));
- CHECK_NE(zero, T.Int32Constant(0));
-
- Type* t = T.upper(zero);
-
- CHECK(t->Is(Type::Number()));
- CHECK(t->Is(Type::Integral32()));
- CHECK(t->Is(Type::Signed32()));
- CHECK(t->Is(Type::Unsigned32()));
- CHECK(t->Is(Type::SignedSmall()));
- CHECK(t->Is(Type::UnsignedSmall()));
-}
-
-
-TEST(MinusZeroConstant) {
- JSConstantCacheTester T;
-
- Node* minus_zero = T.Constant(-0.0);
- Node* zero = T.ZeroConstant();
-
- CHECK_EQ(IrOpcode::kNumberConstant, minus_zero->opcode());
- CHECK_EQ(minus_zero, T.Constant(-0.0));
- CHECK_NE(zero, minus_zero);
-
- Type* t = T.upper(minus_zero);
-
- CHECK(t->Is(Type::Number()));
- CHECK(t->Is(Type::MinusZero()));
- CHECK(!t->Is(Type::Integral32()));
- CHECK(!t->Is(Type::Signed32()));
- CHECK(!t->Is(Type::Unsigned32()));
- CHECK(!t->Is(Type::SignedSmall()));
- CHECK(!t->Is(Type::UnsignedSmall()));
-
- double zero_value = ValueOf<double>(zero->op());
- double minus_zero_value = ValueOf<double>(minus_zero->op());
-
- CHECK_EQ(0.0, zero_value);
- CHECK_NE(-0.0, zero_value);
- CHECK_EQ(-0.0, minus_zero_value);
- CHECK_NE(0.0, minus_zero_value);
-}
-
-
-TEST(ZeroConstant2) {
- JSConstantCacheTester T;
-
- Node* zero = T.Constant(0);
-
- CHECK_EQ(IrOpcode::kNumberConstant, zero->opcode());
- CHECK_EQ(zero, T.ZeroConstant());
- CHECK_NE(zero, T.Constant(-0.0));
- CHECK_NE(zero, T.Constant(1.0));
- CHECK_NE(zero, T.Constant(v8::base::OS::nan_value()));
- CHECK_NE(zero, T.Float64Constant(0));
- CHECK_NE(zero, T.Int32Constant(0));
-
- Type* t = T.upper(zero);
-
- CHECK(t->Is(Type::Number()));
- CHECK(t->Is(Type::Integral32()));
- CHECK(t->Is(Type::Signed32()));
- CHECK(t->Is(Type::Unsigned32()));
- CHECK(t->Is(Type::SignedSmall()));
- CHECK(t->Is(Type::UnsignedSmall()));
-}
-
-
-TEST(OneConstant1) {
- JSConstantCacheTester T;
-
- Node* one = T.OneConstant();
-
- CHECK_EQ(IrOpcode::kNumberConstant, one->opcode());
- CHECK_EQ(one, T.Constant(1));
- CHECK_EQ(one, T.Constant(1.0));
- CHECK_NE(one, T.Constant(1.01));
- CHECK_NE(one, T.Constant(-1.01));
- CHECK_NE(one, T.Constant(v8::base::OS::nan_value()));
- CHECK_NE(one, T.Float64Constant(1.0));
- CHECK_NE(one, T.Int32Constant(1));
-
- Type* t = T.upper(one);
-
- CHECK(t->Is(Type::Number()));
- CHECK(t->Is(Type::Integral32()));
- CHECK(t->Is(Type::Signed32()));
- CHECK(t->Is(Type::Unsigned32()));
- CHECK(t->Is(Type::SignedSmall()));
- CHECK(t->Is(Type::UnsignedSmall()));
-}
-
-
-TEST(OneConstant2) {
- JSConstantCacheTester T;
-
- Node* one = T.Constant(1);
-
- CHECK_EQ(IrOpcode::kNumberConstant, one->opcode());
- CHECK_EQ(one, T.OneConstant());
- CHECK_EQ(one, T.Constant(1.0));
- CHECK_NE(one, T.Constant(1.01));
- CHECK_NE(one, T.Constant(-1.01));
- CHECK_NE(one, T.Constant(v8::base::OS::nan_value()));
- CHECK_NE(one, T.Float64Constant(1.0));
- CHECK_NE(one, T.Int32Constant(1));
-
- Type* t = T.upper(one);
-
- CHECK(t->Is(Type::Number()));
- CHECK(t->Is(Type::Integral32()));
- CHECK(t->Is(Type::Signed32()));
- CHECK(t->Is(Type::Unsigned32()));
- CHECK(t->Is(Type::SignedSmall()));
- CHECK(t->Is(Type::UnsignedSmall()));
-}
-
-
-TEST(Canonicalizations) {
- JSConstantCacheTester T;
-
- CHECK_EQ(T.ZeroConstant(), T.ZeroConstant());
- CHECK_EQ(T.UndefinedConstant(), T.UndefinedConstant());
- CHECK_EQ(T.TheHoleConstant(), T.TheHoleConstant());
- CHECK_EQ(T.TrueConstant(), T.TrueConstant());
- CHECK_EQ(T.FalseConstant(), T.FalseConstant());
- CHECK_EQ(T.NullConstant(), T.NullConstant());
- CHECK_EQ(T.ZeroConstant(), T.ZeroConstant());
- CHECK_EQ(T.OneConstant(), T.OneConstant());
- CHECK_EQ(T.NaNConstant(), T.NaNConstant());
-}
-
-
-TEST(NoAliasing) {
- JSConstantCacheTester T;
-
- Node* nodes[] = {T.UndefinedConstant(), T.TheHoleConstant(), T.TrueConstant(),
- T.FalseConstant(), T.NullConstant(), T.ZeroConstant(),
- T.OneConstant(), T.NaNConstant(), T.Constant(21),
- T.Constant(22.2)};
-
- for (size_t i = 0; i < ARRAY_SIZE(nodes); i++) {
- for (size_t j = 0; j < ARRAY_SIZE(nodes); j++) {
- if (i != j) CHECK_NE(nodes[i], nodes[j]);
- }
- }
-}
-
-
-TEST(CanonicalizingNumbers) {
- JSConstantCacheTester T;
-
- FOR_FLOAT64_INPUTS(i) {
- Node* node = T.Constant(*i);
- for (int j = 0; j < 5; j++) {
- CHECK_EQ(node, T.Constant(*i));
- }
- }
-}
-
-
-TEST(NumberTypes) {
- JSConstantCacheTester T;
-
- FOR_FLOAT64_INPUTS(i) {
- double value = *i;
- Node* node = T.Constant(value);
- CHECK(T.upper(node)->Equals(Type::Of(value, T.main_zone())));
- }
-}
-
-
-TEST(HeapNumbers) {
- JSConstantCacheTester T;
-
- FOR_FLOAT64_INPUTS(i) {
- double value = *i;
- Handle<Object> num = T.factory()->NewNumber(value);
- Handle<HeapNumber> heap = T.factory()->NewHeapNumber(value);
- Node* node1 = T.Constant(value);
- Node* node2 = T.Constant(num);
- Node* node3 = T.Constant(heap);
- CHECK_EQ(node1, node2);
- CHECK_EQ(node1, node3);
- }
-}
-
-
-TEST(OddballHandle) {
- JSConstantCacheTester T;
-
- CHECK_EQ(T.UndefinedConstant(), T.Constant(T.factory()->undefined_value()));
- CHECK_EQ(T.TheHoleConstant(), T.Constant(T.factory()->the_hole_value()));
- CHECK_EQ(T.TrueConstant(), T.Constant(T.factory()->true_value()));
- CHECK_EQ(T.FalseConstant(), T.Constant(T.factory()->false_value()));
- CHECK_EQ(T.NullConstant(), T.Constant(T.factory()->null_value()));
- CHECK_EQ(T.NaNConstant(), T.Constant(T.factory()->nan_value()));
-}
-
-
-TEST(OddballValues) {
- JSConstantCacheTester T;
-
- CHECK_EQ(*T.factory()->undefined_value(), *T.handle(T.UndefinedConstant()));
- CHECK_EQ(*T.factory()->the_hole_value(), *T.handle(T.TheHoleConstant()));
- CHECK_EQ(*T.factory()->true_value(), *T.handle(T.TrueConstant()));
- CHECK_EQ(*T.factory()->false_value(), *T.handle(T.FalseConstant()));
- CHECK_EQ(*T.factory()->null_value(), *T.handle(T.NullConstant()));
-}
-
-
-TEST(OddballTypes) {
- JSConstantCacheTester T;
-
- CHECK(T.upper(T.UndefinedConstant())->Is(Type::Undefined()));
- // TODO(dcarney): figure this out.
- // CHECK(T.upper(T.TheHoleConstant())->Is(Type::Internal()));
- CHECK(T.upper(T.TrueConstant())->Is(Type::Boolean()));
- CHECK(T.upper(T.FalseConstant())->Is(Type::Boolean()));
- CHECK(T.upper(T.NullConstant())->Is(Type::Null()));
- CHECK(T.upper(T.ZeroConstant())->Is(Type::Number()));
- CHECK(T.upper(T.OneConstant())->Is(Type::Number()));
- CHECK(T.upper(T.NaNConstant())->Is(Type::NaN()));
-}
-
-
-TEST(ExternalReferences) {
- // TODO(titzer): test canonicalization of external references.
-}

Powered by Google App Engine
This is Rietveld 408576698