Make sure that there is enough time left before finishing incremental marking in idle notification.

Make sure that there is enough time left before finishing incremental marking in idle notification.

BUG=

[Hannes Payer (out of office), 2014-07-30 10:03:14]

This is the first in a series of refactoring CLs. I left two TODOs for the next
steps.

[ernstm, 2014-07-30 10:33:27]

https://codereview.chromium.org/423303006/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/423303006/diff/1/src/heap.cc#newcode4292
src/heap.cc:4292: int remaining_time = AdvanceIdleIncrementalMarking(step_size);
Isn't the value returned by AdvanceIdleIncrementalMarking the time we already
spent? Maybe rename remaining_time to time_elapsed?

https://codereview.chromium.org/423303006/diff/1/src/heap.cc#newcode4340
src/heap.cc:4340: int remaining_time = AdvanceIdleIncrementalMarking(step_size);
remaining_time -> time_elapsed?

[Hannes Payer (out of office), 2014-07-30 11:48:53]

https://codereview.chromium.org/423303006/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/423303006/diff/1/src/heap.cc#newcode4292
src/heap.cc:4292: int remaining_time = AdvanceIdleIncrementalMarking(step_size);
On 2014/07/30 10:33:26, ernstm wrote:
> Isn't the value returned by AdvanceIdleIncrementalMarking the time we already
> spent? Maybe rename remaining_time to time_elapsed?

yes, that makes sense. actually, we should use the tracer and not a custom timer
here. WDYT?

https://codereview.chromium.org/423303006/diff/1/src/heap.cc#newcode4340
src/heap.cc:4340: int remaining_time = AdvanceIdleIncrementalMarking(step_size);
On 2014/07/30 10:33:26, ernstm wrote:
> remaining_time -> time_elapsed?

yes.

[Hannes Payer (out of office), 2014-07-30 12:52:08]

https://codereview.chromium.org/423303006/diff/20001/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/423303006/diff/20001/src/heap.cc#newcode4290
src/heap.cc:4290: AdvanceIdleIncrementalMarking(step_size);
AdvanceIdleIncrementalMarking does not necessarily result in a trace event. I
will take care of that in a different cl which should be landed before this cl.