Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 423303006: Make sure that there is enough time left before finishing incremental marking in idle notification.

Created:
6 years, 4 months ago by Hannes Payer (out of office)
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Make sure that there is enough time left before finishing incremental marking in idle notification. BUG=

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -11 lines) Patch
M src/gc-tracer.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/gc-tracer.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/heap.cc View 1 4 chunks +25 lines, -10 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
This is the first in a series of refactoring CLs. I left two TODOs for ...
6 years, 4 months ago (2014-07-30 10:03:14 UTC) #1
ernstm
https://codereview.chromium.org/423303006/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/423303006/diff/1/src/heap.cc#newcode4292 src/heap.cc:4292: int remaining_time = AdvanceIdleIncrementalMarking(step_size); Isn't the value returned by ...
6 years, 4 months ago (2014-07-30 10:33:27 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/423303006/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/423303006/diff/1/src/heap.cc#newcode4292 src/heap.cc:4292: int remaining_time = AdvanceIdleIncrementalMarking(step_size); On 2014/07/30 10:33:26, ernstm wrote: ...
6 years, 4 months ago (2014-07-30 11:48:53 UTC) #3
Hannes Payer (out of office)
6 years, 4 months ago (2014-07-30 12:52:08 UTC) #4
https://codereview.chromium.org/423303006/diff/20001/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/423303006/diff/20001/src/heap.cc#newcode4290
src/heap.cc:4290: AdvanceIdleIncrementalMarking(step_size);
AdvanceIdleIncrementalMarking does not necessarily result in a trace event. I
will take care of that in a different cl which should be landed before this cl.

Powered by Google App Engine
This is Rietveld 408576698