third_party/omaha/omaha.gyp - Issue 423293004: Move app_installer into chromium.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/omaha/omaha.gyp

Issue 423293004: Move app_installer into chromium. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 {	5 {

6 'targets': [	6 'targets': [

7 {	7 {

8 'target_name': 'power_gadget',	8 'target_name': 'omaha_extractor',

9 'type': 'static_library',	9 'type': 'static_library',

10 'sources': [	10 'sources': [

11 'PowerGadgetLib.cpp',	11 'src/base/extractor.cc',
	grt (UTC plus 2) 2014/07/31 20:48:06 to avoid the patch, you could put these in src/oma to avoid the patch, you could put these in src/omaha/base (yes, it's repetitive and repetitive) and add 'src' to include_dirs. jackhou1 2014/08/01 00:19:53 Done. Show quoted text On 2014/07/31 20:48:06, grt (no reviews Aug 9 - 27) wrote: > to avoid the patch, you could put these in src/omaha/base (yes, it's repetitive > and repetitive) and add 'src' to include_dirs. Done.
12 'PowerGadgetLib.h',	12 'src/base/extractor.h',

	13 ],

	14 'include_dirs': [

	15 '../..',

13 ],	16 ],

14 },	17 },

15 ],	18 ],

16 }	19 }

OLD	NEW