disables android java.net SSL certificate check needed for webpage

disables android java.net SSL certificate check needed for webpage
record & replay to work with AGSA

BUG=396157
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288114

[wuhu, 2014-07-30 00:28:07]

when you have time, can you please take a look?
thanks

[tonyg, 2014-07-30 00:43:19]

Too bad there's no good way to unittest this.

https://codereview.chromium.org/423213006/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
(right):

https://codereview.chromium.org/423213006/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:216: #
disables java.net SSL certificate check
nit: Please use capitals and punctuation in comments.

Also, I think the comment is more useful if it answers the question "why" rather
than "what".

https://codereview.chromium.org/423213006/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:217:
self._adb.device().RunShellCommand('setprop socket.relaxsslcheck yes')
Since this is only needed for certain browsers, let's guard it with a flag that
backend_settings may set. That way only the browsers that need it set it. Also,
I think this belongs in Start() instead of __init__(). Finally, please use
DeviceUtils.GetProp()/SetProp() instead of RunShellCommand().

https://codereview.chromium.org/423213006/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:312:
self._adb.device().RunShellCommand('setprop socket.relaxsslcheck ""')
This looks too early to me. This happens right after the browser is started. I
think this needs to go into Close().

[wuhu, 2014-07-30 18:37:23]

Thanks Tony for the detailed feedback.

I've made the suggested changes.  Currently, network stack would've been
instantiated once AGSA is started with intent, but that may change in the
future, so it's safer as you pointed out to move the revert piece to Close.

I've also made a change to turn on traffic forwarding when RNDIS is used.  This
is needed for recording.  Do you think it's necessary to create a flag for this
as well?   Are there use cases where RNDIS is used without proxy servers on the
host side?

Thanks

[tonyg, 2014-08-01 00:43:34]

lgtm

https://codereview.chromium.org/423213006/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
(right):

https://codereview.chromium.org/423213006/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:205:
if self.browser_options.netsim or use_rndis_forwarder:
You'll have to sync up this line. I recently added a check for mac. But I think
adding use_rndis_forwarder and removing my mac check is the right fix. So please
just merge away the mac check.

[wuhu, 2014-08-01 15:56:15]

will do, thanks Tony

[wuhu, 2014-08-07 15:34:14]

The CQ bit was checked by wuhu@google.com

[wuhu, 2014-08-07 15:34:18]

The CQ bit was unchecked by wuhu@google.com

[wuhu, 2014-08-07 15:34:28]

The CQ bit was checked by wuhu@google.com

[wuhu, 2014-08-07 15:35:27]

The CQ bit was unchecked by wuhu@google.com

[commit-bot: I haz the power, 2014-08-07 15:35:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wuhu@google.com/423213006/60001

[wuhu, 2014-08-07 15:37:32]

The CQ bit was checked by wuhu@google.com

[wuhu, 2014-08-07 15:37:33]

The CQ bit was unchecked by wuhu@google.com

[wuhu, 2014-08-07 15:37:35]

The CQ bit was checked by wuhu@google.com

[wuhu, 2014-08-07 15:37:36]

The CQ bit was unchecked by wuhu@google.com

[wuhu, 2014-08-07 15:38:57]

The CQ bit was checked by wuhu@google.com

[commit-bot: I haz the power, 2014-08-07 15:43:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wuhu@google.com/423213006/60001

[wuhu, 2014-08-07 18:35:17]

The CQ bit was checked by wuhu@google.com

[commit-bot: I haz the power, 2014-08-07 18:38:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wuhu@google.com/423213006/60001

[commit-bot: I haz the power, 2014-08-07 19:40:53]

Change committed as 288114