Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 423173004: Incorporate glStencilThenCover* nvpr methods (Closed)

Created:
6 years, 4 months ago by Chris Dalton
Modified:
6 years, 4 months ago
Reviewers:
Mark Kilgard, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Incorporate glStencilThenCover* nvpr methods Adds the glStencilThenCover* nvpr methods to GrGLInterface and starts using them. When drawing multible paths, this will make it so we only have to send the index/transform data once. It will also allow the driver to save time internally. The glStencilThenCover* methods are a newer addition, so they aren't available on every driver. In the event that they are not present, we emulate them using the existing glStencil*/glCover* methods. BUG=skia: Committed: https://skia.googlesource.com/skia/+/c8f520466701a14cf2fb86d3f2d3c70983cb4518

Patch Set 1 #

Patch Set 2 : Fix win7 build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -25 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLAssembleGLESInterface.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 1 3 chunks +115 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 2 chunks +35 lines, -24 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Chris Dalton
6 years, 4 months ago (2014-07-29 20:16:14 UTC) #1
bsalomon
lgtm
6 years, 4 months ago (2014-07-29 20:48:38 UTC) #2
Chris Dalton
The CQ bit was checked by cdalton@nvidia.com
6 years, 4 months ago (2014-07-29 21:40:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/423173004/1
6 years, 4 months ago (2014-07-29 21:41:35 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-07-29 21:52:12 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 21:56:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1036)
6 years, 4 months ago (2014-07-29 21:56:29 UTC) #7
Chris Dalton
The CQ bit was checked by cdalton@nvidia.com
6 years, 4 months ago (2014-07-29 22:11:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/423173004/20001
6 years, 4 months ago (2014-07-29 22:12:42 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 22:25:59 UTC) #10
Message was sent while issue was closed.
Change committed as c8f520466701a14cf2fb86d3f2d3c70983cb4518

Powered by Google App Engine
This is Rietveld 408576698