Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 423173002: Use base::STLSetDifference() in place of std::set_difference() (Closed)

Created:
6 years, 4 months ago by byungwook.ahn
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use base::STLSetDifference() in place of std::set_difference() BUG=254066 TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287742

Patch Set 1 #

Patch Set 2 : assign result of STLSetDifference() #

Total comments: 1

Patch Set 3 : add type casting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M content/browser/shared_worker/shared_worker_service_impl.cc View 1 2 1 chunk +4 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
byungwook.ahn
PTAL
6 years, 4 months ago (2014-07-29 17:10:34 UTC) #1
Andrew T Wilson (Slow)
https://codereview.chromium.org/423173002/diff/20001/content/browser/shared_worker/shared_worker_service_impl.cc File content/browser/shared_worker/shared_worker_service_impl.cc (right): https://codereview.chromium.org/423173002/diff/20001/content/browser/shared_worker/shared_worker_service_impl.cc#newcode643 content/browser/shared_worker/shared_worker_service_impl.cc:643: currentworker_depended_renderers); This change won't compile due to a typo ...
6 years, 4 months ago (2014-08-01 15:01:59 UTC) #2
byungwook.ahn
On 2014/08/01 15:01:59, Andrew T Wilson wrote: > https://codereview.chromium.org/423173002/diff/20001/content/browser/shared_worker/shared_worker_service_impl.cc > File content/browser/shared_worker/shared_worker_service_impl.cc (right): > > ...
6 years, 4 months ago (2014-08-03 14:19:04 UTC) #3
Andrew T Wilson (Slow)
On 2014/08/03 14:19:04, byungwook.ahn wrote: > On 2014/08/01 15:01:59, Andrew T Wilson wrote: > > ...
6 years, 4 months ago (2014-08-04 07:58:49 UTC) #4
byungwook.ahn
On 2014/08/04 07:58:49, Andrew T Wilson wrote: > On 2014/08/03 14:19:04, byungwook.ahn wrote: > > ...
6 years, 4 months ago (2014-08-04 22:18:28 UTC) #5
Andrew T Wilson (Slow)
I'm running this through the trybots now. horo@: the only difference I see here is ...
6 years, 4 months ago (2014-08-05 07:35:53 UTC) #6
horo
lgtm
6 years, 4 months ago (2014-08-05 09:22:42 UTC) #7
Andrew T Wilson (Slow)
The CQ bit was checked by atwilson@chromium.org
6 years, 4 months ago (2014-08-05 12:31:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/byungwook.ahn@gmail.com/423173002/40001
6 years, 4 months ago (2014-08-05 12:32:18 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 16:29:00 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 17:11:03 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/1272)
6 years, 4 months ago (2014-08-05 17:11:04 UTC) #12
Andrew T Wilson (Slow)
The CQ bit was checked by atwilson@chromium.org
6 years, 4 months ago (2014-08-06 08:40:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/byungwook.ahn@gmail.com/423173002/40001
6 years, 4 months ago (2014-08-06 08:40:51 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 09:21:14 UTC) #15
Message was sent while issue was closed.
Change committed as 287742

Powered by Google App Engine
This is Rietveld 408576698