|
|
Created:
6 years, 4 months ago by byungwook.ahn Modified:
6 years, 4 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionUse base::STLSetDifference() in place of std::set_difference()
BUG=254066
TEST=NONE
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287742
Patch Set 1 #Patch Set 2 : assign result of STLSetDifference() #
Total comments: 1
Patch Set 3 : add type casting #Messages
Total messages: 15 (0 generated)
PTAL
https://codereview.chromium.org/423173002/diff/20001/content/browser/shared_w... File content/browser/shared_worker/shared_worker_service_impl.cc (right): https://codereview.chromium.org/423173002/diff/20001/content/browser/shared_w... content/browser/shared_worker/shared_worker_service_impl.cc:643: currentworker_depended_renderers); This change won't compile due to a typo - how did you run the tests?
On 2014/08/01 15:01:59, Andrew T Wilson wrote: > https://codereview.chromium.org/423173002/diff/20001/content/browser/shared_w... > File content/browser/shared_worker/shared_worker_service_impl.cc (right): > > https://codereview.chromium.org/423173002/diff/20001/content/browser/shared_w... > content/browser/shared_worker/shared_worker_service_impl.cc:643: > currentworker_depended_renderers); > This change won't compile due to a typo - how did you run the tests? I patched type casting rule and correct a mis typing variables. How can I test for source of "content/browser/shared_worker/"? Please Let me know the command. For example, "$ ninja -C out/Debug chrome unit_tests browser_tests".
On 2014/08/03 14:19:04, byungwook.ahn wrote: > On 2014/08/01 15:01:59, Andrew T Wilson wrote: > > > https://codereview.chromium.org/423173002/diff/20001/content/browser/shared_w... > > File content/browser/shared_worker/shared_worker_service_impl.cc (right): > > > > > https://codereview.chromium.org/423173002/diff/20001/content/browser/shared_w... > > content/browser/shared_worker/shared_worker_service_impl.cc:643: > > currentworker_depended_renderers); > > This change won't compile due to a typo - how did you run the tests? > > I patched type casting rule and correct a mis typing variables. > How can I test for source of "content/browser/shared_worker/"? > Please Let me know the command. > For example, "$ ninja -C out/Debug chrome unit_tests browser_tests". Running browser_tests will probably suffice.
On 2014/08/04 07:58:49, Andrew T Wilson wrote: > On 2014/08/03 14:19:04, byungwook.ahn wrote: > > On 2014/08/01 15:01:59, Andrew T Wilson wrote: > > > > > > https://codereview.chromium.org/423173002/diff/20001/content/browser/shared_w... > > > File content/browser/shared_worker/shared_worker_service_impl.cc (right): > > > > > > > > > https://codereview.chromium.org/423173002/diff/20001/content/browser/shared_w... > > > content/browser/shared_worker/shared_worker_service_impl.cc:643: > > > currentworker_depended_renderers); > > > This change won't compile due to a typo - how did you run the tests? > > > > I patched type casting rule and correct a mis typing variables. > > How can I test for source of "content/browser/shared_worker/"? > > Please Let me know the command. > > For example, "$ ninja -C out/Debug chrome unit_tests browser_tests". > > Running browser_tests will probably suffice. src git:(cr_423173002) ✗ out/Debug/browser_tests tests failed: DownloadExtensionTest.DownloadExtensionTest_AcceptDanger ExtensionActionContextMenuControllerTest.BrowserAction GeolocationBrowserTest.Geoposition WebViewTest.GeolocationAPIEmbedderHasAccessAllow 1 test timed out: WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam/1 Please review this result of browser_tests.
I'm running this through the trybots now. horo@: the only difference I see here is STLSetDifference() calls std::inserter instead of std::back_inserter. I presume that change is innocuous, so I'll land this if it passes the trybots.
lgtm
The CQ bit was checked by atwilson@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/byungwook.ahn@gmail.com/423173002/40001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by atwilson@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/byungwook.ahn@gmail.com/423173002/40001
Message was sent while issue was closed.
Change committed as 287742 |