Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: components/suggestions/suggestions_service.h

Issue 423133003: [Suggestions Service] Add support for expiring the SuggestionsStore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more coding style changes and refactoring Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/suggestions/suggestions_service.h
diff --git a/components/suggestions/suggestions_service.h b/components/suggestions/suggestions_service.h
index ee1ed92ca6afa4f288d455684c805d8aef3cb87b..e1e7c0f0cdb70bb6b983ecc1e4f463ba2a9f1dfb 100644
--- a/components/suggestions/suggestions_service.h
+++ b/components/suggestions/suggestions_service.h
@@ -45,6 +45,8 @@ extern const char kSuggestionsFieldTrialStateParam[];
extern const char kSuggestionsFieldTrialControlParam[];
extern const char kSuggestionsFieldTrialStateEnabled[];
+extern const int64 kDefaultExpiryUsec;
+
// An interface to fetch server suggestions asynchronously.
class SuggestionsService : public KeyedService, public net::URLFetcherDelegate {
public:
@@ -92,6 +94,9 @@ class SuggestionsService : public KeyedService, public net::URLFetcherDelegate {
// Register SuggestionsService related prefs in the Profile prefs.
static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
+ // Sets default timestamp for suggestions which do not have expiry timestamp.
+ void SetDefaultExpiryTimestamps(SuggestionsProfile* suggestions,
+ int64 timestamp_usec);
manzagop (departed) 2014/08/04 19:02:59 nit: I'd align this with SuggestionsProfile.
gayane -on leave until 09-2017 2014/08/04 19:26:44 Done.
private:
FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, BlacklistURLFails);
FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, FetchSuggestionsData);

Powered by Google App Engine
This is Rietveld 408576698