Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: components/suggestions/suggestions_service.h

Issue 423133003: [Suggestions Service] Add support for expiring the SuggestionsStore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Coding style fixes and refactoring Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/suggestions/suggestions_service.h
diff --git a/components/suggestions/suggestions_service.h b/components/suggestions/suggestions_service.h
index ee1ed92ca6afa4f288d455684c805d8aef3cb87b..fee348502ee7a63c50c2874ae0a217acb2648de4 100644
--- a/components/suggestions/suggestions_service.h
+++ b/components/suggestions/suggestions_service.h
@@ -92,6 +92,12 @@ class SuggestionsService : public KeyedService, public net::URLFetcherDelegate {
// Register SuggestionsService related prefs in the Profile prefs.
static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
+ // Sets default timestamp for suggestions which do not have expiry timestamp
Mathieu 2014/08/04 14:39:10 Period at the end of comment.
gayane -on leave until 09-2017 2014/08/04 16:34:58 Done.
+ void SetDefaultExpiryTimestamps(SuggestionsProfile* suggestions,
+ int64 timestamp_usec);
+
+ static const int64 default_expiry_usec = 72 *
Mathieu 2014/08/04 14:39:10 naming style dictates kConstantName
Mathieu 2014/08/04 14:39:10 this constant should be declared above (similar to
gayane -on leave until 09-2017 2014/08/04 16:34:57 Done.
gayane -on leave until 09-2017 2014/08/04 16:34:58 Done.
+ base::Time::kMicrosecondsPerHour;
private:
FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, BlacklistURLFails);
FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, FetchSuggestionsData);

Powered by Google App Engine
This is Rietveld 408576698