components/suggestions/suggestions_service.h - Issue 423133003: [Suggestions Service] Add support for expiring the SuggestionsStore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/suggestions/suggestions_service.h

Issue 423133003: [Suggestions Service] Add support for expiring the SuggestionsStore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Expiry timestamps for suggestions Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/search/suggestions/suggestions_source.cc ('K') | « components/suggestions/proto/suggestions.proto ('k') | components/suggestions/suggestions_service.cc » ('j') | components/suggestions/suggestions_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/suggestions/suggestions_service.h

diff --git a/components/suggestions/suggestions_service.h b/components/suggestions/suggestions_service.h

index ee1ed92ca6afa4f288d455684c805d8aef3cb87b..312ac5310df3de92c04e365c299feff4dbdeacf2 100644

--- a/components/suggestions/suggestions_service.h

+++ b/components/suggestions/suggestions_service.h

@@ -92,6 +92,9 @@ class SuggestionsService : public KeyedService, public net::URLFetcherDelegate {

// Register SuggestionsService related prefs in the Profile prefs.

static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);

+ // adds deafult expiry timestamp if neccessary

manzagop (departed) 2014/07/31 15:31:50 Capitalize.

gayane -on leave until 09-2017 2014/08/04 13:46:30 Done.

+ void AddDefaultExpiryTimestamps(SuggestionsProfile* suggestions);

private:

FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, BlacklistURLFails);

FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, FetchSuggestionsData);