[Suggestions Service] Add support for expiring the SuggestionsStore

components/suggestions/suggestions_service_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/suggestions/suggestions_service.h"
 
 #include <map>
 #include <sstream>
 #include <string>
 
@@ skipping 28 matching lines @@
 namespace {
 
 const char kFakeSuggestionsURL[] = "https://mysuggestions.com/proto";
 const char kFakeSuggestionsCommonParams[] = "foo=bar";
 const char kFakeBlacklistPath[] = "/blacklist";
 const char kFakeBlacklistUrlParam[] = "baz";
 
 const char kTestTitle[] = "a title";
 const char kTestUrl[] = "http://go.com";
 const char kBlacklistUrl[] = "http://blacklist.com";
+const int64 kTestExpiry =
+    (base::Time::NowFromSystemTime() - base::Time::UnixEpoch())
+    .ToInternalValue() + suggestions::kDefaultExpiryUsec;
 
 scoped_ptr<net::FakeURLFetcher> CreateURLFetcher(
     const GURL& url, net::URLFetcherDelegate* delegate,
     const std::string& response_data, net::HttpStatusCode response_code,
     net::URLRequestStatus::Status status) {
   scoped_ptr<net::FakeURLFetcher> fetcher(new net::FakeURLFetcher(
       url, delegate, response_data, response_code, status));
 
   if (response_code == net::HTTP_OK) {
     scoped_refptr<net::HttpResponseHeaders> download_headers(
@@ skipping 28 matching lines @@
 namespace suggestions {
 
 scoped_ptr<SuggestionsProfile> CreateSuggestionsProfile() {
   scoped_ptr<SuggestionsProfile> profile(new SuggestionsProfile());
   ChromeSuggestion* suggestion = profile->add_suggestions();
   suggestion->set_title(kTestTitle);
   suggestion->set_url(kTestUrl);
   return profile.Pass();
 }
 
+// Creates one suggestion with expiry timestamp and one without.
+SuggestionsProfile CreateSuggestionsProfileWithExpiryTimestamps() {
+  int64 now = (base::Time::NowFromSystemTime() - base::Time::UnixEpoch())
+      .ToInternalValue();
+  SuggestionsProfile profile;
+  ChromeSuggestion* suggestion = profile.add_suggestions();
+  suggestion->set_title(kTestTitle);
+  suggestion->set_url(kTestUrl);
+  suggestion->set_expiry_ts(now);
+
+  suggestion = profile.add_suggestions();
+  suggestion->set_title(kTestTitle);
+  suggestion->set_url(kTestUrl);
+
+  return profile;
+}
+
 class MockSuggestionsStore : public suggestions::SuggestionsStore {
  public:
   MOCK_METHOD1(LoadSuggestions, bool(SuggestionsProfile*));
   MOCK_METHOD1(StoreSuggestions, bool(const SuggestionsProfile&));
   MOCK_METHOD0(ClearSuggestions, void());
 };
 
 class MockImageManager : public suggestions::ImageManager {
  public:
   MockImageManager() {}
@@ skipping 383 matching lines @@
 
   // Delay increases on failure.
   suggestions_service->UpdateBlacklistDelay(false);
   EXPECT_GT(suggestions_service->blacklist_delay(), initial_delay);
 
   // Delay resets on success.
   suggestions_service->UpdateBlacklistDelay(true);
   EXPECT_EQ(initial_delay, suggestions_service->blacklist_delay());
 }
 
+TEST_F(SuggestionsServiceTest, CheckDefaultTimeStamps) {
+  scoped_ptr<SuggestionsService> suggestions_service(
+      CreateSuggestionsServiceWithMocks());
+  SuggestionsProfile suggestions =
+      CreateSuggestionsProfileWithExpiryTimestamps();
+  suggestions_service->SetDefaultExpiryTimestamp(&suggestions, kTestExpiry);
+  EXPECT_NE(suggestions.suggestions(0).expiry_ts(), kTestExpiry);

[manzagop (departed), 2014/08/05 15:30:26]

An equality test is a stronger statement. I'd keep the equality test you had for
this one.

Sorry if my previous comment was unclear: typically a comment will apply to the
line right above it.

[gayane -on leave until 09-2017, 2014/08/06 14:40:55]

Done.

+  EXPECT_EQ(suggestions.suggestions(1).expiry_ts(), kTestExpiry);
+}
 }  // namespace suggestions