Source/core/svg/SVGLinearGradientElement.cpp - Issue 423093014: [SVG2] Make transform, gradientTransform and patternTransform presentation attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGLinearGradientElement.cpp

Issue 423093014: [SVG2] Make transform, gradientTransform and patternTransform presentation attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: transform attr syntax should match property, with minor quirks Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGLinearGradientElement.cpp

diff --git a/Source/core/svg/SVGLinearGradientElement.cpp b/Source/core/svg/SVGLinearGradientElement.cpp

index f1f35b6edfd3447404aaf5273d40613203e52159..ec137a4542447a3b61e876a58df0013fb804f60e 100644

--- a/Source/core/svg/SVGLinearGradientElement.cpp

+++ b/Source/core/svg/SVGLinearGradientElement.cpp

@@ -113,10 +113,8 @@ static void setGradientAttributes(SVGGradientElement* element, LinearGradientAtt

if (!attributes.hasGradientUnits() && element->gradientUnits()->isSpecified())

attributes.setGradientUnits(element->gradientUnits()->currentValue()->enumValue());

- if (!attributes.hasGradientTransform() && element->gradientTransform()->isSpecified()) {

- AffineTransform transform;

- element->gradientTransform()->currentValue()->concatenate(transform);

- attributes.setGradientTransform(transform);

+ if (!attributes.hasGradientTransform()) {

+ attributes.setGradientTransformFromStyle(element);

}

if (!attributes.hasStops()) {

« Source/core/svg/SVGGraphicsElement.cpp ('K') | « Source/core/svg/SVGGraphicsElement.cpp ('k') | Source/core/svg/SVGPatternElement.h » ('j') | Source/core/svg/SVGPatternElement.cpp » ('J')