[SVG2] Make transform, gradientTransform and patternTransform presentation attributes.

Source/core/svg/SVGGraphicsElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
  * Copyright (C) 2014 Google, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 25 matching lines @@
     , SVGTests(this)
     , m_transform(SVGAnimatedTransformList::create(this, SVGNames::transformAttr, SVGTransformList::create()))
 {
     addToPropertyMap(m_transform);
 }
 
 SVGGraphicsElement::~SVGGraphicsElement()
 {
 }
 
+bool SVGGraphicsElement::isPresentationAttribute(const QualifiedName& name) const
+{
+    if (name == SVGNames::transformAttr)
+        return true;
+    return SVGElement::isPresentationAttribute(name);
+}
+
+void SVGGraphicsElement::collectStyleForPresentationAttribute(const QualifiedName& name, const AtomicString& value, MutableStylePropertySet* style)
+{
+    if (name == SVGNames::transformAttr)
+        addPropertyToPresentationAttributeStyle(style, CSSPropertyTransform, value);
+    else
+        SVGElement::collectStyleForPresentationAttribute(name, value, style);
+}
+
 PassRefPtr<SVGMatrixTearOff> SVGGraphicsElement::getTransformToElement(SVGElement* target, ExceptionState& exceptionState)
 {
     AffineTransform ctm = getCTM(AllowStyleUpdate);
 
     if (target && target->isSVGGraphicsElement()) {
         AffineTransform targetCTM = toSVGGraphicsElement(target)->getCTM(AllowStyleUpdate);
         if (!targetCTM.isInvertible()) {
             exceptionState.throwDOMException(InvalidStateError, "The target transformation is not invertable.");
             return nullptr;
         }
@@ skipping 139 matching lines @@
     if (SVGTests::isKnownAttribute(attrName)) {
         lazyReattachIfAttached();
         return;
     }
 
     RenderObject* object = renderer();
     if (!object)
         return;
 
     if (attrName == SVGNames::transformAttr) {
+        invalidateSVGPresentationAttributeStyle();

[pdr., 2014/08/01 22:43:10]

We don't make these calls for many other other presentation attributes in SVG
(e.g., SVGSVGElement's width and height, or SVGImageElement's width and height),
nor for the new pattern and gradient presentation attributes. Why is this
different?

[Erik Dahlström (inactive), 2014/08/04 13:57:57]

We do call invalidateSVGPresentationAttributeStyle(); and
setNeedsStyleRecalc(LocalStyleChange); for the width/height attributes that have
been made presentation attributes (see SVGSVGElement and
SVGForeignObjectElement).

The gradient and pattern ones were missing, will add.

The reasoning behind this is in
http://code.google.com/p/chromium/issues/detail?id=364807.

+        setNeedsStyleRecalc(SubtreeStyleChange);
         object->setNeedsTransformUpdate();
         RenderSVGResource::markForLayoutAndParentResourceInvalidation(object);
         return;
     }
 
     ASSERT_NOT_REACHED();
 }
 
 SVGElement* SVGGraphicsElement::nearestViewportElement() const
 {
@@ skipping 38 matching lines @@
 }
 
 void SVGGraphicsElement::toClipPath(Path& path)
 {
     updatePathFromGraphicsElement(this, path);
     // FIXME: How do we know the element has done a layout?
     path.transform(animatedLocalTransform());
 }
 
 }