LayoutTests/svg/custom/transform-invalid.svg - Issue 423093014: [SVG2] Make transform, gradientTransform and patternTransform presentation attributes.

Side by Side Diff: LayoutTests/svg/custom/transform-invalid.svg

Issue 423093014: [SVG2] Make transform, gradientTransform and patternTransform presentation attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: transform attr syntax should match property, with minor quirks Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/svg/custom/gradient-transform-invalid-expected.svg ('k') | LayoutTests/svg/custom/transform-invalid-expected.txt » ('j') | Source/core/svg/GradientAttributes.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8" standalone="no"?>	1 <?xml version="1.0" encoding="UTF-8" standalone="no"?>

2 <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.0//EN" "http://www.w3.org/TR/2001/REC-SV G-20010904/DTD/svg10.dtd">	2 <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.0//EN" "http://www.w3.org/TR/2001/REC-SV G-20010904/DTD/svg10.dtd">

3 <svg xmlns="http://www.w3.org/2000/svg" width="200" height="200" viewBox="0 0 20 0 200">	3 <svg xmlns="http://www.w3.org/2000/svg" width="200" height="200" viewBox="0 0 20 0 200">

4 <!-- Both of these previously caused crashes, but now should be ignored. -->	4 <!-- Both of these previously caused crashes, but now should be ignored. -->

5 <rect width="100" height="100" transform="foo(20,20)" fill="green"/>	5 <rect width="100" height="100" transform="foo(20,20)" fill="green"/>

6 <rect width="100" height="100" transform="scale()" fill="green"/>	6 <rect width="100" height="100" transform="scale()" fill="green"/>

7 <rect width="100" height="100" transform="scale(20,20,20)" fill="green"/ >	7 <rect width="100" height="100" transform="scale(20,20,20)" fill="green"/ >

8 <rect width="100" height="100" transform="scale(20,)" fill="green"/>	8 <rect width="100" height="100" transform="scale(20,)" fill="green"/>

9 <rect width="100" height="100" transform="scale(20,,)" fill="green"/>	9 <rect width="100" height="100" transform="scale(20,,)" fill="green"/>

10 <rect width="100" height="100" transform="scale(20" fill="green"/>
pdr. 2014/08/01 22:43:10 Did you mean to remove this line? Did you mean to remove this line? Erik Dahlström (inactive) 2014/08/04 13:57:57 CSS.supports("transform", "scale(20") returns true Show quoted text On 2014/08/01 22:43:10, pdr wrote: > Did you mean to remove this line? CSS.supports("transform", "scale(20") returns true on ToT, which might be a bug in the css parser (though Firefox Nightly returns the same too), in any case this is the reason why I removed this line. If you wish I can add a corresponding line in LayoutTests/transforms/transform-parsing.html, I don't see why we would want the parser to differ here. Whatever the CSS parser allows for transform should be allowed in the presentation attribute.
11 <rect width="100" height="100" transform="scale 20)" fill="green"/>	10 <rect width="100" height="100" transform="scale 20)" fill="green"/>

12 <rect width="100" height="100" transform="scale(r)" fill="green"/>	11 <rect width="100" height="100" transform="scale(r)" fill="green"/>

13 <rect width="100" height="100" transform="translate()" fill="green"/>	12 <rect width="100" height="100" transform="translate()" fill="green"/>

14 <rect width="100" height="100" transform="translate(20,20,20)" fill="gre en"/>	13 <rect width="100" height="100" transform="translate(20,20,20)" fill="gre en"/>

15 <rect width="100" height="100" transform="translate(20,)" fill="green"/>	14 <rect width="100" height="100" transform="translate(20,)" fill="green"/>

16 <rect width="100" height="100" transform="translate(20,,)" fill="green"/ >	15 <rect width="100" height="100" transform="translate(20,,)" fill="green"/ >

17 <rect width="100" height="100" transform="translate(20" fill="green"/>	16 <rect width="100" height="100" transform="translate(20" fill="green"/>

18 <rect width="100" height="100" transform="translate 20)" fill="green"/>	17 <rect width="100" height="100" transform="translate 20)" fill="green"/>

19 <rect width="100" height="100" transform="translate(r)" fill="green"/>	18 <rect width="100" height="100" transform="translate(r)" fill="green"/>

20 <rect width="100" height="100" transform="skewX()" fill="green"/>	19 <rect width="100" height="100" transform="skewX()" fill="green"/>

21 <rect width="100" height="100" transform="skewX(20,20,20)" fill="green"/ >	20 <rect width="100" height="100" transform="skewX(20,20,20)" fill="green"/ >

22 <rect width="100" height="100" transform="skewX(20,)" fill="green"/>	21 <rect width="100" height="100" transform="skewX(20,)" fill="green"/>

23 <rect width="100" height="100" transform="skewX(20,,)" fill="green"/>	22 <rect width="100" height="100" transform="skewX(20,,)" fill="green"/>

24 <rect width="100" height="100" transform="skewX(20" fill="green"/>	23 <rect width="100" height="100" transform="skewX(20" fill="green"/>

25 <rect width="100" height="100" transform="skewX 20)" fill="green"/>	24 <rect width="100" height="100" transform="skewX 20)" fill="green"/>

26 <rect width="100" height="100" transform="skewX(r)" fill="green"/>	25 <rect width="100" height="100" transform="skewX(r)" fill="green"/>

27 <rect width="100" height="100" transform="skewY()" fill="green"/>	26 <rect width="100" height="100" transform="skewY()" fill="green"/>

28 <rect width="100" height="100" transform="skewY(20,20,20)" fill="green"/ >	27 <rect width="100" height="100" transform="skewY(20,20,20)" fill="green"/ >

29 <rect width="100" height="100" transform="skewY(20,)" fill="green"/>	28 <rect width="100" height="100" transform="skewY(20,)" fill="green"/>

30 <rect width="100" height="100" transform="skewY(20,,)" fill="green"/>	29 <rect width="100" height="100" transform="skewY(20,,)" fill="green"/>

31 <rect width="100" height="100" transform="skewY(20" fill="green"/>	30 <rect width="100" height="100" transform="skewY(20" fill="green"/>

32 <rect width="100" height="100" transform="skewY 20)" fill="green"/>	31 <rect width="100" height="100" transform="skewY 20)" fill="green"/>

33 <rect width="100" height="100" transform="skewY(r)" fill="green"/>	32 <rect width="100" height="100" transform="skewY(r)" fill="green"/>

34 <rect width="100" height="100" transform="scale(20), scale(1) ," fill=" green"/>	33 <rect width="100" height="100" transform="scale(20), scale(1) ," fill=" green"/>

35 </svg>	34 </svg>

OLD	NEW