Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Side by Side Diff: src/arm64/lithium-arm64.cc

Issue 423093009: Ensure LModByPowerOf2I only gets environment when it deopts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arm64/lithium-arm64.h" 7 #include "src/arm64/lithium-arm64.h"
8 #include "src/arm64/lithium-codegen-arm64.h" 8 #include "src/arm64/lithium-codegen-arm64.h"
9 #include "src/hydrogen-osr.h" 9 #include "src/hydrogen-osr.h"
10 #include "src/lithium-allocator-inl.h" 10 #include "src/lithium-allocator-inl.h"
(...skipping 1838 matching lines...) Expand 10 before | Expand all | Expand 10 after
1849 1849
1850 1850
1851 LInstruction* LChunkBuilder::DoModByPowerOf2I(HMod* instr) { 1851 LInstruction* LChunkBuilder::DoModByPowerOf2I(HMod* instr) {
1852 ASSERT(instr->representation().IsInteger32()); 1852 ASSERT(instr->representation().IsInteger32());
1853 ASSERT(instr->left()->representation().Equals(instr->representation())); 1853 ASSERT(instr->left()->representation().Equals(instr->representation()));
1854 ASSERT(instr->right()->representation().Equals(instr->representation())); 1854 ASSERT(instr->right()->representation().Equals(instr->representation()));
1855 LOperand* dividend = UseRegisterAtStart(instr->left()); 1855 LOperand* dividend = UseRegisterAtStart(instr->left());
1856 int32_t divisor = instr->right()->GetInteger32Constant(); 1856 int32_t divisor = instr->right()->GetInteger32Constant();
1857 LInstruction* result = DefineSameAsFirst(new(zone()) LModByPowerOf2I( 1857 LInstruction* result = DefineSameAsFirst(new(zone()) LModByPowerOf2I(
1858 dividend, divisor)); 1858 dividend, divisor));
1859 if (instr->CheckFlag(HValue::kBailoutOnMinusZero)) { 1859 if (instr->CheckFlag(HValue::kLeftCanBeNegative) &&
1860 instr->CheckFlag(HValue::kBailoutOnMinusZero)) {
1860 result = AssignEnvironment(result); 1861 result = AssignEnvironment(result);
1861 } 1862 }
1862 return result; 1863 return result;
1863 } 1864 }
1864 1865
1865 1866
1866 LInstruction* LChunkBuilder::DoModByConstI(HMod* instr) { 1867 LInstruction* LChunkBuilder::DoModByConstI(HMod* instr) {
1867 ASSERT(instr->representation().IsInteger32()); 1868 ASSERT(instr->representation().IsInteger32());
1868 ASSERT(instr->left()->representation().Equals(instr->representation())); 1869 ASSERT(instr->left()->representation().Equals(instr->representation()));
1869 ASSERT(instr->right()->representation().Equals(instr->representation())); 1870 ASSERT(instr->right()->representation().Equals(instr->representation()));
(...skipping 877 matching lines...) Expand 10 before | Expand all | Expand 10 after
2747 HAllocateBlockContext* instr) { 2748 HAllocateBlockContext* instr) {
2748 LOperand* context = UseFixed(instr->context(), cp); 2749 LOperand* context = UseFixed(instr->context(), cp);
2749 LOperand* function = UseRegisterAtStart(instr->function()); 2750 LOperand* function = UseRegisterAtStart(instr->function());
2750 LAllocateBlockContext* result = 2751 LAllocateBlockContext* result =
2751 new(zone()) LAllocateBlockContext(context, function); 2752 new(zone()) LAllocateBlockContext(context, function);
2752 return MarkAsCall(DefineFixed(result, cp), instr); 2753 return MarkAsCall(DefineFixed(result, cp), instr);
2753 } 2754 }
2754 2755
2755 2756
2756 } } // namespace v8::internal 2757 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698