Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 423093009: Ensure LModByPowerOf2I only gets environment when it deopts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm64/lithium-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arm/lithium-arm.h" 7 #include "src/arm/lithium-arm.h"
8 #include "src/arm/lithium-codegen-arm.h" 8 #include "src/arm/lithium-codegen-arm.h"
9 #include "src/hydrogen-osr.h" 9 #include "src/hydrogen-osr.h"
10 #include "src/lithium-allocator-inl.h" 10 #include "src/lithium-allocator-inl.h"
(...skipping 1399 matching lines...) Expand 10 before | Expand all | Expand 10 after
1410 1410
1411 1411
1412 LInstruction* LChunkBuilder::DoModByPowerOf2I(HMod* instr) { 1412 LInstruction* LChunkBuilder::DoModByPowerOf2I(HMod* instr) {
1413 ASSERT(instr->representation().IsSmiOrInteger32()); 1413 ASSERT(instr->representation().IsSmiOrInteger32());
1414 ASSERT(instr->left()->representation().Equals(instr->representation())); 1414 ASSERT(instr->left()->representation().Equals(instr->representation()));
1415 ASSERT(instr->right()->representation().Equals(instr->representation())); 1415 ASSERT(instr->right()->representation().Equals(instr->representation()));
1416 LOperand* dividend = UseRegisterAtStart(instr->left()); 1416 LOperand* dividend = UseRegisterAtStart(instr->left());
1417 int32_t divisor = instr->right()->GetInteger32Constant(); 1417 int32_t divisor = instr->right()->GetInteger32Constant();
1418 LInstruction* result = DefineSameAsFirst(new(zone()) LModByPowerOf2I( 1418 LInstruction* result = DefineSameAsFirst(new(zone()) LModByPowerOf2I(
1419 dividend, divisor)); 1419 dividend, divisor));
1420 if (instr->CheckFlag(HValue::kBailoutOnMinusZero)) { 1420 if (instr->CheckFlag(HValue::kLeftCanBeNegative) &&
1421 instr->CheckFlag(HValue::kBailoutOnMinusZero)) {
1421 result = AssignEnvironment(result); 1422 result = AssignEnvironment(result);
1422 } 1423 }
1423 return result; 1424 return result;
1424 } 1425 }
1425 1426
1426 1427
1427 LInstruction* LChunkBuilder::DoModByConstI(HMod* instr) { 1428 LInstruction* LChunkBuilder::DoModByConstI(HMod* instr) {
1428 ASSERT(instr->representation().IsSmiOrInteger32()); 1429 ASSERT(instr->representation().IsSmiOrInteger32());
1429 ASSERT(instr->left()->representation().Equals(instr->representation())); 1430 ASSERT(instr->left()->representation().Equals(instr->representation()));
1430 ASSERT(instr->right()->representation().Equals(instr->representation())); 1431 ASSERT(instr->right()->representation().Equals(instr->representation()));
(...skipping 1189 matching lines...) Expand 10 before | Expand all | Expand 10 after
2620 LInstruction* LChunkBuilder::DoAllocateBlockContext( 2621 LInstruction* LChunkBuilder::DoAllocateBlockContext(
2621 HAllocateBlockContext* instr) { 2622 HAllocateBlockContext* instr) {
2622 LOperand* context = UseFixed(instr->context(), cp); 2623 LOperand* context = UseFixed(instr->context(), cp);
2623 LOperand* function = UseRegisterAtStart(instr->function()); 2624 LOperand* function = UseRegisterAtStart(instr->function());
2624 LAllocateBlockContext* result = 2625 LAllocateBlockContext* result =
2625 new(zone()) LAllocateBlockContext(context, function); 2626 new(zone()) LAllocateBlockContext(context, function);
2626 return MarkAsCall(DefineFixed(result, cp), instr); 2627 return MarkAsCall(DefineFixed(result, cp), instr);
2627 } 2628 }
2628 2629
2629 } } // namespace v8::internal 2630 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm64/lithium-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698