Source/core/rendering/RenderScrollbar.h - Issue 423093002: Oilpan: Prepare to move RenderObject and RenderObjectChildList to Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderScrollbar.h

Issue 423093002: Oilpan: Prepare to move RenderObject and RenderObjectChildList to Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add more trace Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderLayerReflectionInfo.h ('K') | « Source/core/rendering/RenderQuote.cpp ('k') | Source/core/rendering/RenderTableCellTest.cpp » ('j') | Source/core/rendering/RenderTableCellTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderScrollbar.h

diff --git a/Source/core/rendering/RenderScrollbar.h b/Source/core/rendering/RenderScrollbar.h

index 70b1d0a55feb5553f4908a728d94d5b7c5aa7ea2..73b5b810d5574a848f2c58b48eccb097c2070251 100644

--- a/Source/core/rendering/RenderScrollbar.h

+++ b/Source/core/rendering/RenderScrollbar.h

@@ -84,7 +84,7 @@ private:

RefPtrWillBePersistent<Node> m_owner;

LocalFrame* m_owningFrame;

- HashMap<unsigned, RenderScrollbarPart*> m_parts;

+ WillBePersistentHeapHashMap<unsigned, RawPtrWillBeMember<RenderScrollbarPart> > m_parts;

haraken 2014/08/01 17:48:21 Are you sure that these Members don't cause leaks?

tkent 2014/08/07 04:43:03 I'm sure. RenderScrollbar owns these RenderScroll

};

DEFINE_TYPE_CASTS(RenderScrollbar, ScrollbarThemeClient, scrollbar, scrollbar->isCustomScrollbar(), scrollbar.isCustomScrollbar());