Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Unified Diff: Source/core/frame/FrameView.h

Issue 423093002: Oilpan: Prepare to move RenderObject and RenderObjectChildList to Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add more trace Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/FrameView.h
diff --git a/Source/core/frame/FrameView.h b/Source/core/frame/FrameView.h
index ccceafc19c051cfa4a6ce725f0d6260670b3cc4e..5162754300ad24b57201a839cfa50ad68a7d9078 100644
--- a/Source/core/frame/FrameView.h
+++ b/Source/core/frame/FrameView.h
@@ -419,11 +419,11 @@ private:
LayoutSize m_size;
- typedef HashSet<RefPtr<RenderEmbeddedObject> > EmbeddedObjectSet;
- EmbeddedObjectSet m_widgetUpdateSet;
+ typedef WillBeHeapHashSet<RefPtrWillBeMember<RenderEmbeddedObject> > EmbeddedObjectSet;
+ WillBePersistentHeapHashSet<RefPtrWillBeMember<RenderEmbeddedObject> > m_widgetUpdateSet;
// FIXME: These are just "children" of the FrameView and should be RefPtr<Widget> instead.
- HashSet<RefPtr<RenderWidget> > m_widgets;
+ WillBePersistentHeapHashSet<RefPtrWillBeMember<RenderWidget> > m_widgets;
RefPtr<LocalFrame> m_frame;
@@ -483,7 +483,7 @@ private:
RefPtrWillBePersistent<Node> m_maintainScrollPositionAnchor;
// Renderer to hold our custom scroll corner.
- RenderScrollbarPart* m_scrollCorner;
+ RawPtrWillBePersistent<RenderScrollbarPart> m_scrollCorner;
haraken 2014/08/01 17:48:21 This doesn't need to be a Persistent. I'd prefer k
tkent 2014/08/07 04:43:03 No, this must not be a raw pointer. FrameView owns
// If true, automatically resize the frame view around its content.
bool m_shouldAutoSize;

Powered by Google App Engine
This is Rietveld 408576698