Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1810)

Unified Diff: net/disk_cache/backend_unittest.cc

Issue 42309: Avoid valgrinding unit tests that intentionally leak memory,... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/data/valgrind/net_unittests.gtest.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/backend_unittest.cc
===================================================================
--- net/disk_cache/backend_unittest.cc (revision 12023)
+++ net/disk_cache/backend_unittest.cc (working copy)
@@ -356,6 +356,14 @@
// The same logic of the previous test (ValidEntry), but this time force the
// entry to be invalid, simulating a crash in the middle.
// We'll be leaking memory from this test.
+//
+// This and the other intentionally leaky tests below are excluded from
+// purify and valgrind runs by naming them in the files
+// net/data/purify/net_unittests.exe.gtest.txt and
+// net/data/valgrind/net_unittests.gtest.txt
+// The scripts tools/{purify,valgrind}/chrome_tests.sh
+// read those files and pass the appropriate --gtest_filter to net_unittests.
+//
TEST_F(DiskCacheBackendTest, InvalidEntry) {
// Use the implementation directly... we need to simulate a crash.
SetDirectMode();
« no previous file with comments | « net/data/valgrind/net_unittests.gtest.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698