Add new hotword extension for built-in hotword triggering.

Add new hotword extension for built-in hotword triggering.

This is just a skeleton of the extension and doesn't have any functionality.

Can't use the existing hotword_helper since this has a hard dependency
on a shared module (which doesn't yet exist).

BUG=397019
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288956

[Anand Mistry (off Chromium), 2014-07-29 07:29:05]

jhawkins: Not sure who to send this to, so I just picked you since you reviewed
the hotword_helper extension. Please re-direct to someone more appropriate.

[kcarattini, 2014-07-30 03:39:30]

lgtm

[Anand Mistry (off Chromium), 2014-08-04 23:41:10]

James: Ping!

[James Hawkins, 2014-08-05 08:59:45]

https://codereview.chromium.org/423083002/diff/1/chrome/browser/extensions/co...
File chrome/browser/extensions/component_loader.cc (right):

https://codereview.chromium.org/423083002/diff/1/chrome/browser/extensions/co...
chrome/browser/extensions/component_loader.cc:313: #if defined(OS_CHROMEOS)
Please get rid of this #ifdef by creating a ChromeOS implementation of
ComponentLoader which inherits from ComponentLoader and overwrites this method. 
See any of the other _chromeos.[h,cc] files in this directory for examples.

https://codereview.chromium.org/423083002/diff/1/chrome/browser/extensions/ex...
File chrome/browser/extensions/external_component_loader.cc (right):

https://codereview.chromium.org/423083002/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/external_component_loader.cc:50: CommandLine*
command_line = CommandLine::ForCurrentProcess();
Same as component_loader, create a ChromeOS-specific implementation instead of
using #ifdef.

https://codereview.chromium.org/423083002/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword/manager.js (right):

https://codereview.chromium.org/423083002/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword/manager.js:13: * provided by a shared module
loaded from the web store.
So this is just a stub on purpose?

[Anand Mistry (off Chromium), 2014-08-06 01:46:07]

https://codereview.chromium.org/423083002/diff/1/chrome/browser/extensions/co...
File chrome/browser/extensions/component_loader.cc (right):

https://codereview.chromium.org/423083002/diff/1/chrome/browser/extensions/co...
chrome/browser/extensions/component_loader.cc:313: #if defined(OS_CHROMEOS)
On 2014/08/05 08:59:45, James Hawkins wrote:
> Please get rid of this #ifdef by creating a ChromeOS implementation of
> ComponentLoader which inherits from ComponentLoader and overwrites this
method. 
> See any of the other _chromeos.[h,cc] files in this directory for examples.

I've been meaning to change this flag and move it into chrome since it's not
chromeos-specific. I've done that in 442183002 and rebased this change onto
that.

https://codereview.chromium.org/423083002/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword/manager.js (right):

https://codereview.chromium.org/423083002/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword/manager.js:13: * provided by a shared module
loaded from the web store.
On 2014/08/05 08:59:45, James Hawkins wrote:
> So this is just a stub on purpose?

Yes, for now.

[James Hawkins, 2014-08-08 09:20:18]

LGTM with an issue in manifest.json to resolve.

https://codereview.chromium.org/423083002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/hotword/manifest.json (right):

https://codereview.chromium.org/423083002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/manifest.json:30: // TODO(amistry): For now,
use a locally modified version of the external
FWIW I don't think comments are supported in manifest.json.

[Anand Mistry (off Chromium), 2014-08-11 00:43:59]

https://codereview.chromium.org/423083002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/hotword/manifest.json (right):

https://codereview.chromium.org/423083002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/manifest.json:30: // TODO(amistry): For now,
use a locally modified version of the external
On 2014/08/08 09:20:18, James Hawkins wrote:
> FWIW I don't think comments are supported in manifest.json.

In what way? Locally, I have working extension that builds on this change, and
it has no problems handling this comment.

[benwells, 2014-08-11 06:15:18]

On 2014/08/11 00:43:59, Anand Mistry wrote:
>
https://codereview.chromium.org/423083002/diff/20001/chrome/browser/resources...
> File chrome/browser/resources/hotword/manifest.json (right):
> 
>
https://codereview.chromium.org/423083002/diff/20001/chrome/browser/resources...
> chrome/browser/resources/hotword/manifest.json:30: // TODO(amistry): For now,
> use a locally modified version of the external
> On 2014/08/08 09:20:18, James Hawkins wrote:
> > FWIW I don't think comments are supported in manifest.json.
> 
> In what way? Locally, I have working extension that builds on this change, and
> it has no problems handling this comment.

You won't be able to upload the extension to the webstore, as it's json parser
can't handle comments (the json spec doesn't allow comments). The one in chrome
can.

[Anand Mistry (off Chromium), 2014-08-11 07:04:57]

On 2014/08/11 06:15:18, benwells wrote:
> On 2014/08/11 00:43:59, Anand Mistry wrote:
> >
>
https://codereview.chromium.org/423083002/diff/20001/chrome/browser/resources...
> > File chrome/browser/resources/hotword/manifest.json (right):
> > 
> >
>
https://codereview.chromium.org/423083002/diff/20001/chrome/browser/resources...
> > chrome/browser/resources/hotword/manifest.json:30: // TODO(amistry): For
now,
> > use a locally modified version of the external
> > On 2014/08/08 09:20:18, James Hawkins wrote:
> > > FWIW I don't think comments are supported in manifest.json.
> > 
> > In what way? Locally, I have working extension that builds on this change,
and
> > it has no problems handling this comment.
> 
> You won't be able to upload the extension to the webstore, as it's json parser
> can't handle comments (the json spec doesn't allow comments). The one in
chrome
> can.

But this extension isn't going into the webstore. Also, 18/30 extensions/apps in
chrome/browser/resources contain at least one comment.

[benwells, 2014-08-11 07:15:59]

On 2014/08/11 07:04:57, Anand Mistry wrote:
> On 2014/08/11 06:15:18, benwells wrote:
> > On 2014/08/11 00:43:59, Anand Mistry wrote:
> > >
> >
>
https://codereview.chromium.org/423083002/diff/20001/chrome/browser/resources...
> > > File chrome/browser/resources/hotword/manifest.json (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/423083002/diff/20001/chrome/browser/resources...
> > > chrome/browser/resources/hotword/manifest.json:30: // TODO(amistry): For
> now,
> > > use a locally modified version of the external
> > > On 2014/08/08 09:20:18, James Hawkins wrote:
> > > > FWIW I don't think comments are supported in manifest.json.
> > > 
> > > In what way? Locally, I have working extension that builds on this change,
> and
> > > it has no problems handling this comment.
> > 
> > You won't be able to upload the extension to the webstore, as it's json
parser
> > can't handle comments (the json spec doesn't allow comments). The one in
> chrome
> > can.
> 
> But this extension isn't going into the webstore. Also, 18/30 extensions/apps
in
> chrome/browser/resources contain at least one comment.

Shouldn't be an issue then. I was just explaining what James was referring to.

[James Hawkins, 2014-08-11 14:17:11]

lgtm

[Anand Mistry (off Chromium), 2014-08-12 00:03:45]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2014-08-12 00:06:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/amistry@chromium.org/423083002/60001

[commit-bot: I haz the power, 2014-08-12 01:52:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-12 14:31:46]

Change committed as 288956