Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 423073009: Fix race in locale changes during DeviceLocalAccountTest (Closed)

Created:
6 years, 4 months ago by bartfab (slow)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix race in locale changes during DeviceLocalAccountTest OOBE shows the network selection screen first. This screen will change the application locale when it finishes loading and once again when it loses focus. This CL ensures that tests wait until both events have happened before proceeding so that locale switches initiated by the network selection screen do not interfere with the locale switching code that is actually under test. BUG=214904, 241790 TEST=DeviceLocalAccountTest.SelectLanguageAndKeyboardWithTermsOfService R=pneubeck@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287350

Patch Set 1 #

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -20 lines) Patch
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 4 chunks +37 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bartfab (slow)
Hi Philipp, Could you take a look?
6 years, 4 months ago (2014-08-04 13:38:07 UTC) #1
pneubeck (no reviews)
lgtm
6 years, 4 months ago (2014-08-04 14:51:50 UTC) #2
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 4 months ago (2014-08-04 14:58:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/423073009/20001
6 years, 4 months ago (2014-08-04 14:59:02 UTC) #4
bartfab (slow)
The CQ bit was unchecked by bartfab@chromium.org
6 years, 4 months ago (2014-08-04 16:29:08 UTC) #5
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 4 months ago (2014-08-04 16:44:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/423073009/20001
6 years, 4 months ago (2014-08-04 16:45:38 UTC) #7
bartfab (slow)
6 years, 4 months ago (2014-08-04 16:51:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as 287350 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698