Issue 423073008: Fix build on Win64 for tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 423073008: Fix build on Win64 for tests. (Closed)

Created:
6 years, 4 months ago by titzer

Modified:
6 years, 4 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix build on Win64 for tests. R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22820

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -15 lines)			Patch
	M	test/cctest/compiler/test-simplified-lowering.cc	View		4 chunks	+16 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

titzer

Committed patchset #1 manually as 22820 (tree was closed).

6 years, 4 months ago (2014-08-04 13:27:40 UTC) #3

Sven Panne

6 years, 4 months ago (2014-08-04 13:32:04 UTC) #4

Message was sent while issue was closed.

On 2014/08/04 13:27:40, titzer wrote:
> Committed patchset #1 manually as 22820 (tree was closed).

This breaks the x64 build:

../test/cctest/compiler/test-simplified-lowering.cc: In function ‘void
TestRunLoadFieldFromUntaggedBase()’:
../test/cctest/compiler/test-simplified-lowering.cc:326:77: error: narrowing
conversion of ‘(i * 8ul)’ from ‘size_t {aka long unsigned int}’ to ‘int’ inside
{ } [-fpermissive]

etc.

Expand Messages | Collapse Messages