Issue 423073004: Fix diff generation by difflib to report missing end of file newlines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 423073004: Fix diff generation by difflib to report missing end of file newlines. (Closed)

Created:
6 years, 4 months ago by elecro

Modified:
6 years, 4 months ago

Reviewers:
Dirk Pranke, dpranke, eseidel

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Fix diff generation by difflib to report missing end of file newlines. The diff generated by the difflib is incorrect if one of the files does not have a newline at the end of the file and the last lines are different. Relevant Python issue: http://bugs.python.org/issue2142 BUG=398435 TEST=test-webkitpy Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180764

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	Tools/Scripts/webkitpy/layout_tests/port/base.py	View		1 chunk	+11 lines, -1 line	0 comments	Download
	M	Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

elecro

The CQ bit was checked by pgal.u-szeged@partner.samsung.com

6 years, 4 months ago (2014-08-22 08:20:24 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgal.u-szeged@partner.samsung.com/423073004/1

6 years, 4 months ago (2014-08-22 08:21:01 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...

6 years, 4 months ago (2014-08-22 09:18:51 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (1) as 180764