Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 422963002: Propagate disallow_fullscreen_for_non_media_elements to renderer. (Closed)

Created:
6 years, 4 months ago by Ignacio Solla
Modified:
6 years, 4 months ago
Reviewers:
philipj_slow, jam, qinmin, dcheng
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Propagate disallow_fullscreen_for_non_media_elements to renderer. We are setting it here: https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/native/aw_settings.cc&l=437 But we are not yet propagating it to blink because this line was missing. This change will only be landed after the next blink deps roll including: https://codereview.chromium.org/422923002/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286189

Patch Set 1 #

Patch Set 2 : Changes to render_view_impl.cc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/public/common/common_param_traits_macros.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ignacio Solla
6 years, 4 months ago (2014-07-28 18:00:08 UTC) #1
dcheng
This variable never seems to be read after it's written? Where is the code that's ...
6 years, 4 months ago (2014-07-28 18:04:59 UTC) #2
Ignacio Solla
On 2014/07/28 18:04:59, dcheng (OOO) wrote: > This variable never seems to be read after ...
6 years, 4 months ago (2014-07-28 18:06:36 UTC) #3
dcheng
lgtm
6 years, 4 months ago (2014-07-28 18:09:25 UTC) #4
Ignacio Solla
On 2014/07/28 18:09:25, dcheng (OOO) wrote: > lgtm Uploaded a new version, with some changes ...
6 years, 4 months ago (2014-07-28 18:20:12 UTC) #5
Ignacio Solla
jam@chromium.org: Please review changes in
6 years, 4 months ago (2014-07-28 18:21:18 UTC) #6
jam
lgtm
6 years, 4 months ago (2014-07-28 23:00:49 UTC) #7
Ignacio Solla
The CQ bit was checked by igsolla@chromium.org
6 years, 4 months ago (2014-07-29 09:51:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igsolla@chromium.org/422963002/20001
6 years, 4 months ago (2014-07-29 09:53:46 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 14:03:30 UTC) #10
Message was sent while issue was closed.
Change committed as 286189

Powered by Google App Engine
This is Rietveld 408576698