Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9641)

Unified Diff: chrome/renderer/resources/neterror.html

Issue 422933002: Shift the error page "More" button over to text. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Next round of comments incorporated. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/neterror.html
diff --git a/chrome/renderer/resources/neterror.html b/chrome/renderer/resources/neterror.html
index a6ba1dbded2f97c9fa2a6fd162ff652a6950dcfe..4540057c9c423a5282ca4f92a75ea27597265b4c 100644
--- a/chrome/renderer/resources/neterror.html
+++ b/chrome/renderer/resources/neterror.html
@@ -20,20 +20,25 @@
<span i18n-content="heading"></span>
</h1>
<div id="buttons">
- <button id="reload-button" class="blue-button text-button"
- onclick="trackClick(this.trackingId);
- reloadButtonClick(this.url);"
- jsselect="reloadButton"
- jsvalues=".url:reloadUrl; .trackingId:reloadTrackingId"
- jscontent="msg"></button>
- <button id="stale-load-button" class="blue-button text-button"
- onclick="loadStaleButtonClick()"
- jsselect="staleLoadButton"
- jscontent="msg" jsvalues="title:title"></button>
- <button id="more-less-button" class="text-button"
- onclick="moreButtonClick(); toggleHelpBox()"
- jsdisplay="more" jsvalues=".moreText:more; .lessText:less;"
- jscontent="more"></button>
+ <div id="control-buttons">
mmenke 2014/08/01 20:56:51 optional: Maybe rename the outer div controls, an
Randy Smith (Not in Mondays) 2014/08/01 21:48:19 So I'm still calling the Details link a details bu
+ <button id="reload-button"
+ class="blue-button text-button"
+ onclick="trackClick(this.trackingId);
+ reloadButtonClick(this.url);"
+ jsselect="reloadButton"
+ jsvalues=".url:reloadUrl; .trackingId:reloadTrackingId"
+ jscontent="msg"></button>
+ <button id="stale-load-button"
+ class="blue-button text-button"
+ onclick="loadStaleButtonClick()"
+ jsselect="staleLoadButton"
+ jscontent="msg" jsvalues="title:title"></button>
+ </div>
mmenke 2014/08/01 20:56:51 Replace tabs with spaces.
Randy Smith (Not in Mondays) 2014/08/01 21:48:19 Arggh--gotta do some emacs hacking (emacs does thi
+ <a href="#" id="details-button" class="active-text"
+ onclick="detailsButtonClick(); toggleHelpBox()"
+ jsdisplay="details" jscontent="details"
+ jsvalues=".detailsText:details; .hideDetailsText:hideDetails;">
+ </a>
</div>
</div>
<!-- Outer and inner divs are needed both for margins and sizing. -->

Powered by Google App Engine
This is Rietveld 408576698