Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/renderer/resources/neterror.html

Issue 422933002: Shift the error page "More" button over to text. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/renderer/resources/neterror.css ('k') | chrome/renderer/resources/neterror.js » ('j') | chrome/renderer/resources/neterror.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html i18n-values="dir:textdirection"> 2 <html i18n-values="dir:textdirection">
3 <head> 3 <head>
4 <meta charset="utf-8"> 4 <meta charset="utf-8">
5 <meta name="viewport" content="width=device-width, initial-scale=1.0, 5 <meta name="viewport" content="width=device-width, initial-scale=1.0,
6 maximum-scale=1.0, user-scalable=no"> 6 maximum-scale=1.0, user-scalable=no">
7 <title i18n-content="title"></title> 7 <title i18n-content="title"></title>
8 <link rel="stylesheet" href="neterror.css"> 8 <link rel="stylesheet" href="neterror.css">
9 <script src="neterror.js"></script> 9 <script src="neterror.js"></script>
10 </head> 10 </head>
11 <body id="t"> 11 <body id="t">
12 <div id="main-frame-error"> 12 <div id="main-frame-error">
13 <div id="box"> 13 <div id="box">
14 <div id="content-top"> 14 <div id="content-top">
15 <h1> 15 <h1>
16 <div> 16 <div>
17 <img class="icon" 17 <img class="icon"
18 jseval="updateIconClass(this.classList, iconClass)"> 18 jseval="updateIconClass(this.classList, iconClass)">
19 </div> 19 </div>
20 <span i18n-content="heading"></span> 20 <span i18n-content="heading"></span>
21 </h1> 21 </h1>
22 <div id="buttons"> 22 <div id="buttons">
23 <button id="reload-button" class="blue-button text-button" 23 <button id="reload-button"
24 » class="blue-button text-button"
mmenke 2014/08/01 18:29:33 Don't use tabs.
Randy Smith (Not in Mondays) 2014/08/01 20:28:23 Done.
24 onclick="trackClick(this.trackingId); 25 onclick="trackClick(this.trackingId);
25 reloadButtonClick(this.url);" 26 reloadButtonClick(this.url);"
26 jsselect="reloadButton" 27 jsselect="reloadButton"
27 jsvalues=".url:reloadUrl; .trackingId:reloadTrackingId" 28 jsvalues=".url:reloadUrl; .trackingId:reloadTrackingId"
28 jscontent="msg"></button> 29 jscontent="msg"></button>
29 <button id="stale-load-button" class="blue-button text-button" 30 <button id="stale-load-button"
30 onclick="loadStaleButtonClick()" 31 » class="blue-button text-button"
32 onclick="loadStaleButtonClick()"
31 jsselect="staleLoadButton" 33 jsselect="staleLoadButton"
32 jscontent="msg" jsvalues="title:title"></button> 34 jscontent="msg" jsvalues="title:title"></button>
33 <button id="more-less-button" class="text-button" 35 <a href="#" id="details-button" class="active-text"
34 onclick="moreButtonClick(); toggleHelpBox()" 36 onclick="detailsButtonClick(); toggleHelpBox()"
35 jsdisplay="more" jsvalues=".moreText:more; .lessText:less;" 37 jsdisplay="details" jscontent="details"
36 jscontent="more"></button> 38 » jsvalues=".detailsText:details; .hideDetailsText:hideDetails;">
39 » </a>
37 </div> 40 </div>
38 </div> 41 </div>
39 <!-- Outer and inner divs are needed both for margins and sizing. --> 42 <!-- Outer and inner divs are needed both for margins and sizing. -->
40 <div id="help-box-outer" class="hidden"> 43 <div id="help-box-outer" class="hidden">
41 <div id="help-box-inner"> 44 <div id="help-box-inner">
42 <div jsselect="summary"> 45 <div jsselect="summary">
43 <span jsvalues=".innerHTML:msg"></span> 46 <span jsvalues=".innerHTML:msg"></span>
44 </div> 47 </div>
45 <div class="suggestions" jsselect="suggestions"> 48 <div class="suggestions" jsselect="suggestions">
46 <div class="suggestion-header" jsvalues=".innerHTML:header"></div> 49 <div class="suggestion-header" jsvalues=".innerHTML:header"></div>
(...skipping 23 matching lines...) Expand all
70 </div> 73 </div>
71 <div id="sub-frame-error"> 74 <div id="sub-frame-error">
72 <!-- Show details when hovering over the icon, in case the details are 75 <!-- Show details when hovering over the icon, in case the details are
73 hidden because they're too large. --> 76 hidden because they're too large. -->
74 <img class="icon" jseval="updateIconClass(this.classList, iconClass)" 77 <img class="icon" jseval="updateIconClass(this.classList, iconClass)"
75 jsvalues=".title:errorDetails"> 78 jsvalues=".title:errorDetails">
76 <div id="sub-frame-error-details" jsvalues=".innerHTML:errorDetails"></div> 79 <div id="sub-frame-error-details" jsvalues=".innerHTML:errorDetails"></div>
77 </div> 80 </div>
78 </body> 81 </body>
79 </html> 82 </html>
OLDNEW
« no previous file with comments | « chrome/renderer/resources/neterror.css ('k') | chrome/renderer/resources/neterror.js » ('j') | chrome/renderer/resources/neterror.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698