Track usage of "this" and "arguments" in Scope

src/ast-value-factory.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 70 matching lines @@
   bool is_one_byte() const { return is_one_byte_; }
   bool IsOneByteEqualTo(const char* data) const;
   uint16_t FirstCharacter() const {
     if (is_one_byte_)
       return literal_bytes_[0];
     const uint16_t* c =
         reinterpret_cast<const uint16_t*>(literal_bytes_.start());
     return *c;
   }
 
+  bool IsArguments() const { return IsOneByteEqualTo("arguments"); }

[marja, 2014/08/11 08:51:39]

This doesn't look correct. The AstStrings are unique, so you should be able to
compare the AstString* to AstValueFactory::arguments_string().

Is the problem that where this is used, there's no AstValueFactory? If so, that
should probably be fixed... I mean, surely the AstValueFactory is *somewhere*
since we managed to create the AstString...

+
   // For storing AstRawStrings in a hash map.
   uint32_t hash() const {
     return hash_;
   }
   static bool Compare(void* a, void* b);
 
  private:
   friend class AstValueFactory;
   friend class AstRawStringInternalizationKey;
 
@@ skipping 234 matching lines @@
   const AstRawString* name##_string_;
   STRING_CONSTANTS(F)
 #undef F
 };
 
 } }  // namespace v8::internal
 
 #undef STRING_CONSTANTS
 
 #endif  // V8_AST_VALUE_FACTORY_H_