gdb : importing gdb webkit path

gdb : importing gdb webkit path

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286779

[kishorags_, 2014-07-28 13:49:34]

PTAL. Thanks

[Jeffrey Yasskin, 2014-07-28 19:39:39]

lgtm after the two changes below. Thanks!

https://codereview.chromium.org/422883002/diff/1/tools/gdb/gdb_chrome.py
File tools/gdb/gdb_chrome.py (right):

https://codereview.chromium.org/422883002/diff/1/tools/gdb/gdb_chrome.py#newc...
tools/gdb/gdb_chrome.py:14: This module relies on the WebKit gdb module already
existing in
Please remove this instruction now that you've fixed the problem that requires
it.

https://codereview.chromium.org/422883002/diff/1/tools/gdb/gdb_chrome.py#newc...
tools/gdb/gdb_chrome.py:28: sys.path.insert(0,
os.path.join(os.path.dirname(os.path.abspath(__file__)),
It's a bit safer to remove the element of sys.path again once the import is
finished. Use:

sys.path.insert(0, os.path.join(
    os.path.dirname(os.path.abspath(__file__)),
    '..', '..', 'third_party', 'WebKit', 'Tools', 'gdb'))
try:
  import webkit
finally:
  sys.path.pop(0)

[kishorags_, 2014-07-31 03:20:19]

The CQ bit was checked by kishor.ag@samsung.com

[kishorags_, 2014-07-31 03:22:04]

On 2014/07/28 19:39:39, Jeffrey Yasskin wrote:
> lgtm after the two changes below. Thanks!
> 
> https://codereview.chromium.org/422883002/diff/1/tools/gdb/gdb_chrome.py
> File tools/gdb/gdb_chrome.py (right):
> 
>
https://codereview.chromium.org/422883002/diff/1/tools/gdb/gdb_chrome.py#newc...
> tools/gdb/gdb_chrome.py:14: This module relies on the WebKit gdb module
already
> existing in
> Please remove this instruction now that you've fixed the problem that requires
> it.
> 
>
https://codereview.chromium.org/422883002/diff/1/tools/gdb/gdb_chrome.py#newc...
> tools/gdb/gdb_chrome.py:28: sys.path.insert(0,
> os.path.join(os.path.dirname(os.path.abspath(__file__)),
> It's a bit safer to remove the element of sys.path again once the import is
> finished. Use:
> 
> sys.path.insert(0, os.path.join(
>     os.path.dirname(os.path.abspath(__file__)),
>     '..', '..', 'third_party', 'WebKit', 'Tools', 'gdb'))
> try:
>   import webkit
> finally:
>   sys.path.pop(0)

Thanks for the review

[commit-bot: I haz the power, 2014-07-31 03:26:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kishor.ag@samsung.com/422883002/20001

[commit-bot: I haz the power, 2014-07-31 13:03:24]

Change committed as 286779