Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 422883002: gdb : importing gdb webkit path (Closed)

Created:
6 years, 4 months ago by kishorags_
Modified:
6 years, 4 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gdb : importing gdb webkit path BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286779

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated review comments #

Patch Set 3 : Changed checking sequence of attached device list & device option #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/adb_install_apk.py View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kishorags_
PTAL. Thanks
6 years, 4 months ago (2014-07-28 13:49:34 UTC) #1
Jeffrey Yasskin
lgtm after the two changes below. Thanks! https://codereview.chromium.org/422883002/diff/1/tools/gdb/gdb_chrome.py File tools/gdb/gdb_chrome.py (right): https://codereview.chromium.org/422883002/diff/1/tools/gdb/gdb_chrome.py#newcode14 tools/gdb/gdb_chrome.py:14: This module ...
6 years, 4 months ago (2014-07-28 19:39:39 UTC) #2
kishorags_
The CQ bit was checked by kishor.ag@samsung.com
6 years, 4 months ago (2014-07-31 03:20:19 UTC) #3
kishorags_
On 2014/07/28 19:39:39, Jeffrey Yasskin wrote: > lgtm after the two changes below. Thanks! > ...
6 years, 4 months ago (2014-07-31 03:22:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kishor.ag@samsung.com/422883002/20001
6 years, 4 months ago (2014-07-31 03:26:32 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 13:03:24 UTC) #6
Message was sent while issue was closed.
Change committed as 286779

Powered by Google App Engine
This is Rietveld 408576698