bindings: Introduces ScriptWrappableBase to provide the internal pointer.

bindings: Introduces ScriptWrappableBase to provide the internal pointer.

Introduces ScriptWrappableBase class in order to provide the internal pointer independent from V8Type.

The end to end change will be http://crrev.com/420233002

BUG=235436
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179098

[Yuki, 2014-07-28 13:33:18]

Could you review this CL?

[kouhei (in TOK), 2014-07-28 13:40:05]

https://codereview.chromium.org/422873002/diff/1/Source/bindings/core/v8/Scri...
File Source/bindings/core/v8/ScriptWrappable.h (right):

https://codereview.chromium.org/422873002/diff/1/Source/bindings/core/v8/Scri...
Source/bindings/core/v8/ScriptWrappable.h:62: return
static_cast<T*>(static_cast<ScriptWrappableBase*>(internalPointer));
As previously discussed, woudl it be possible to add a check that T is not
inheriting multiple ScriptWrappableBases?

[Yuki, 2014-07-28 15:26:03]

https://codereview.chromium.org/422873002/diff/1/Source/bindings/core/v8/Scri...
File Source/bindings/core/v8/ScriptWrappable.h (right):

https://codereview.chromium.org/422873002/diff/1/Source/bindings/core/v8/Scri...
Source/bindings/core/v8/ScriptWrappable.h:62: return
static_cast<T*>(static_cast<ScriptWrappableBase*>(internalPointer));
On 2014/07/28 13:40:05, kouhei wrote:
> As previously discussed, woudl it be possible to add a check that T is not
> inheriting multiple ScriptWrappableBases?

Done.

[kouhei (in TOK), 2014-07-28 15:28:34]

lgtm

[haraken, 2014-07-28 15:43:57]

LGTM

https://codereview.chromium.org/422873002/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/ScriptWrappable.cpp (right):

https://codereview.chromium.org/422873002/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/ScriptWrappable.cpp:29: */

Use the 3-line copyright.

[Yuki, 2014-07-28 15:48:14]

https://codereview.chromium.org/422873002/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/ScriptWrappable.cpp (right):

https://codereview.chromium.org/422873002/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/ScriptWrappable.cpp:29: */
On 2014/07/28 15:43:57, haraken wrote:
> 
> Use the 3-line copyright.

Sorry, what's the 3-line copyright?  I just copy&pasted this copyright from
ScriptWrappable.h.

[haraken, 2014-07-28 15:50:48]

On 2014/07/28 15:48:14, Yuki wrote:
>
https://codereview.chromium.org/422873002/diff/20001/Source/bindings/core/v8/...
> File Source/bindings/core/v8/ScriptWrappable.cpp (right):
> 
>
https://codereview.chromium.org/422873002/diff/20001/Source/bindings/core/v8/...
> Source/bindings/core/v8/ScriptWrappable.cpp:29: */
> On 2014/07/28 15:43:57, haraken wrote:
> > 
> > Use the 3-line copyright.
> 
> Sorry, what's the 3-line copyright?  I just copy&pasted this copyright from
> ScriptWrappable.h.

Since 2014, we started using the following copyright. Actually ScriptWrappable.h
should have used it as well (we don't need to rewrite existing ones).

// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

[Yuki, 2014-07-29 04:25:08]

On 2014/07/28 15:50:48, haraken wrote:
> On 2014/07/28 15:48:14, Yuki wrote:
> >
>
https://codereview.chromium.org/422873002/diff/20001/Source/bindings/core/v8/...
> > File Source/bindings/core/v8/ScriptWrappable.cpp (right):
> > 
> >
>
https://codereview.chromium.org/422873002/diff/20001/Source/bindings/core/v8/...
> > Source/bindings/core/v8/ScriptWrappable.cpp:29: */
> > On 2014/07/28 15:43:57, haraken wrote:
> > > 
> > > Use the 3-line copyright.
> > 
> > Sorry, what's the 3-line copyright?  I just copy&pasted this copyright from
> > ScriptWrappable.h.
> 
> Since 2014, we started using the following copyright. Actually
ScriptWrappable.h
> should have used it as well (we don't need to rewrite existing ones).
> 
> // Copyright 2014 The Chromium Authors. All rights reserved.
> // Use of this source code is governed by a BSD-style license that can be
> // found in the LICENSE file.

Got it and updated the file.  Will commit.

[Yuki, 2014-07-29 04:25:17]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2014-07-29 04:25:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yukishiino@chromium.org/422873002/40001

[commit-bot: I haz the power, 2014-07-29 05:30:53]

Change committed as 179098