Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 422863003: adb_gdb : Change Device's SELinux mode as part of adb_gdb script (Closed)

Created:
6 years, 4 months ago by kishorags_
Modified:
6 years ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

adb_gdb : Changing the Device's SELinux Mode to Permissive when Enforcing Mode is detected BUG=399517 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287353

Patch Set 1 #

Patch Set 2 : updated AUTHORS #

Patch Set 3 : Changes to set Permissive mode when Enforcing mode is detected #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M build/android/adb_gdb View 1 2 1 chunk +14 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kishorags_
PTAL
6 years, 4 months ago (2014-07-28 12:11:52 UTC) #1
kishorags_
Gentle Ping. Thanks
6 years, 4 months ago (2014-07-31 09:48:38 UTC) #2
aurimas (slooooooooow)
On 2014/07/31 09:48:38, kishorags_ wrote: > Gentle Ping. Thanks Please add a bug number to ...
6 years, 4 months ago (2014-07-31 15:16:44 UTC) #3
kishorags_
On 2014/07/31 15:16:44, aurimas wrote: > On 2014/07/31 09:48:38, kishorags_ wrote: > > Gentle Ping. ...
6 years, 4 months ago (2014-08-01 11:23:16 UTC) #4
aurimas (slooooooooow)
Sorry for a slow response. LGTM
6 years, 4 months ago (2014-08-04 15:26:46 UTC) #5
kishorags_
On 2014/08/04 15:26:46, aurimas wrote: > Sorry for a slow response. LGTM Thanks
6 years, 4 months ago (2014-08-04 15:29:16 UTC) #6
kishorags_
The CQ bit was checked by kishor.ag@samsung.com
6 years, 4 months ago (2014-08-04 15:29:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kishor.ag@samsung.com/422863003/40001
6 years, 4 months ago (2014-08-04 15:30:25 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-04 16:39:43 UTC) #9
commit-bot: I haz the power
Change committed as 287353
6 years, 4 months ago (2014-08-04 17:03:40 UTC) #10
bcwhite
Not all installation of Android (perhaps only non-rooted ones) have an "su" binary. Can you ...
6 years ago (2014-11-28 19:22:38 UTC) #11
bcwhite
6 years ago (2014-11-28 19:28:19 UTC) #12
Message was sent while issue was closed.
Let me try that again.  If the "su" command is not present, the script crashes
with "too many arguments to [" because the adb_shell command returns more than a
single argument.  Just enclosing it in double-quotes should fix that.

The "getenforce" command seems to run just fine as a regular user, though it's
returning "Enforcing" and would then try to run "setenforce 0" which fails as a
regular user.

Powered by Google App Engine
This is Rietveld 408576698