Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 422853004: Revert of Disable flaky tests related to "Cannot read property 'textdirection' of undefined" (Closed)

Created:
6 years, 4 months ago by engedy
Modified:
6 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky tests related to "Cannot read property 'textdirection' of undefined" (https://codereview.chromium.org/413913002/) Reason for revert: The flakes seem to have been caused by http://src.chromium.org/viewvc/blink?revision=178571&view=revision, which have been since reverted in https://codereview.chromium.org/418783002/ and rolled to Chromium in https://codereview.chromium.org/418713003. The errors can no longer be reproduced with ToT. Pushing revert through CQ and try bots to make sure this is also the case on the bots. Original issue's description: > Disable flaky tests related to "Cannot read property 'textdirection' of undefined". > > BUG=396752 > R=kalman@chromium.org > TBR=ben@chromium.org, dbeam@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285100 TBR=dbeam@chromium.org,kalman@chromium.org,ben@chromium.org,stgao@chromium.org BUG=396752 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_browsertest.js View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/guest_mode_options_ui_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
engedy
Created Revert of Disable flaky tests related to "Cannot read property 'textdirection' of undefined"
6 years, 4 months ago (2014-07-28 11:18:48 UTC) #1
engedy
The CQ bit was checked by engedy@chromium.org
6 years, 4 months ago (2014-07-28 11:19:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/engedy@chromium.org/422853004/1
6 years, 4 months ago (2014-07-28 11:20:54 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-28 14:02:01 UTC) #4
commit-bot: I haz the power
Change committed as 285912
6 years, 4 months ago (2014-07-28 15:48:28 UTC) #5
Dan Beam
6 years, 4 months ago (2014-07-28 17:02:58 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698