Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 422853003: Remove all compilation related interface from the StubCache (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove all compilation related interface from the StubCache BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22678

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Make the PropertyICCompiler constructor private #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -232 lines) Patch
M src/arm/stub-cache-arm.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M src/arm64/stub-cache-arm64.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M src/ic.cc View 1 17 chunks +30 lines, -28 lines 0 comments Download
M src/stub-cache.h View 1 2 11 chunks +58 lines, -79 lines 0 comments Download
M src/stub-cache.cc View 21 chunks +91 lines, -89 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-07-28 10:58:07 UTC) #1
Igor Sheludko
lgtm
6 years, 4 months ago (2014-07-29 15:31:16 UTC) #2
Toon Verwaest
6 years, 4 months ago (2014-07-29 16:04:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r22678 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698