Issue 422843009: Add a new CldDataSource class that can be queried at runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 422843009: Add a new CldDataSource class that can be queried at runtime. (Closed)

Created:
6 years, 4 months ago by Andrew Hayden (chromium.org)

Modified:
6 years, 4 months ago

Reviewers:
Takashi Toyoshima, simonb (inactive), simonb1

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add a new CldDataSource class that can be queried at runtime. This will allow several "#if defined" statements to be replaced with runtime checks, simplifying the build process and eliminating the need to generate multiple libraries for several targets when building Android's chrome_shell in the presence of non-static CLD data sources. BUG=367239 TBR=toyoshim Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286177

Patch Set 1 #

Patch Set 2 : Add BUILD.gn #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -6 lines)			Patch
M	components/translate.gypi	View		2 chunks	+16 lines, -0 lines	0 comments	Download
M	components/translate/content/common/BUILD.gn	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
A	components/translate/content/common/cld_data_source.h	View		1 chunk	+33 lines, -0 lines	0 comments	Download
A +	components/translate/content/common/component_cld_data_source.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
A +	components/translate/content/common/standalone_cld_data_source.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
A +	components/translate/content/common/static_cld_data_source.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Andrew Hayden (chromium.org)

Note, git is very confused on the diffs here, all the files other than translate.gypi ...

6 years, 4 months ago (2014-07-29 06:54:10 UTC) #1

Andrew Hayden (chromium.org)

The CQ bit was checked by andrewhayden@chromium.org

6 years, 4 months ago (2014-07-29 10:51:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/422843009/20001

6 years, 4 months ago (2014-07-29 10:52:33 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages